From: Mike Christie <michaelc@cs.wisc.edu>
To: David Jeffery <dhjeffery@gmail.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC] Reduce amount of TURs sent in error recovery
Date: Tue, 29 Mar 2011 18:09:45 -0500 [thread overview]
Message-ID: <4D9266B9.40209@cs.wisc.edu> (raw)
In-Reply-To: <4D80F6D0.1010404@gmail.com>
On 03/16/2011 12:43 PM, David Jeffery wrote:
> +static int scsi_eh_test_devices(struct list_head *cmd_list, struct list_head *work_q, struct list_head *done_q, int try_stu)
> +{
> + struct scsi_cmnd *scmd, *next;
> + struct scsi_device *sdev;
> + int finish_cmds;
> +
> + while(!list_empty(cmd_list)){
Just some small nits. I think you need some white spaces. Other code
does "while (!list_empty(cmd_list)) {"
> + scmd = list_entry(cmd_list->next, struct scsi_cmnd, eh_entry);
> + sdev = scmd->device;
> +
> + finish_cmds = !scsi_device_online(scmd->device) ||
> + (try_stu&& !scsi_eh_try_stu(scmd)&& !scsi_eh_tur(scmd)) ||
> + !scsi_eh_tur(scmd);
> +
> + list_for_each_entry_safe(scmd, next, cmd_list, eh_entry)
> + if (scmd->device == sdev) {
> + if(finish_cmds)
Need space here too.
next prev parent reply other threads:[~2011-03-29 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 17:43 [PATCH RFC] Reduce amount of TURs sent in error recovery David Jeffery
2011-03-29 23:09 ` Mike Christie [this message]
2011-04-11 0:52 ` Mark Goodwin
2011-04-11 5:59 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9266B9.40209@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=dhjeffery@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).