* [PATCH 1/1] ipr: fix synchronous request flags for better performance
[not found] <20110331165142.303106723@linux.vnet.ibm.com>
@ 2011-03-31 16:56 ` Wayne Boyer
2011-03-31 17:51 ` Brian King
0 siblings, 1 reply; 2+ messages in thread
From: Wayne Boyer @ 2011-03-31 16:56 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, Brian King
In testing it was noticed that Extended Delay after Reset flag was being set
for gscsi and volume set devices. This had a negative effect on performance
for volume sets. The fix is to only set the flag for gscsi devices.
Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 3 ++-
drivers/scsi/ipr.h | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
Index: b/drivers/scsi/ipr.c
===================================================================
--- a/drivers/scsi/ipr.c 2011-03-31 09:48:18.998471040 -0700
+++ b/drivers/scsi/ipr.c 2011-03-31 09:48:50.318094131 -0700
@@ -5773,7 +5773,8 @@ static int ipr_queuecommand_lck(struct s
}
ioarcb->cmd_pkt.flags_hi |= IPR_FLAGS_HI_NO_LINK_DESC;
- ioarcb->cmd_pkt.flags_lo |= IPR_FLAGS_LO_DELAY_AFTER_RST;
+ if (ipr_is_gscsi(res))
+ ioarcb->cmd_pkt.flags_lo |= IPR_FLAGS_LO_DELAY_AFTER_RST;
ioarcb->cmd_pkt.flags_lo |= IPR_FLAGS_LO_ALIGNED_BFR;
ioarcb->cmd_pkt.flags_lo |= ipr_get_task_attributes(scsi_cmd);
}
Index: b/drivers/scsi/ipr.h
===================================================================
--- a/drivers/scsi/ipr.h 2011-03-31 09:48:20.438637636 -0700
+++ b/drivers/scsi/ipr.h 2011-03-31 09:49:19.381456240 -0700
@@ -474,7 +474,7 @@ struct ipr_cmd_pkt {
u8 flags_lo;
#define IPR_FLAGS_LO_ALIGNED_BFR 0x20
-#define IPR_FLAGS_LO_DELAY_AFTER_RST 0x10
+#define IPR_FLAGS_LO_DELAY_AFTER_RST 0x10
#define IPR_FLAGS_LO_UNTAGGED_TASK 0x00
#define IPR_FLAGS_LO_SIMPLE_TASK 0x02
#define IPR_FLAGS_LO_ORDERED_TASK 0x04
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ipr: fix synchronous request flags for better performance
2011-03-31 16:56 ` [PATCH 1/1] ipr: fix synchronous request flags for better performance Wayne Boyer
@ 2011-03-31 17:51 ` Brian King
0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2011-03-31 17:51 UTC (permalink / raw)
To: Wayne Boyer; +Cc: James Bottomley, linux-scsi
Acked-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-31 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110331165142.303106723@linux.vnet.ibm.com>
2011-03-31 16:56 ` [PATCH 1/1] ipr: fix synchronous request flags for better performance Wayne Boyer
2011-03-31 17:51 ` Brian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).