From: Mike Christie <michaelc@cs.wisc.edu>
To: Mark Goodwin <mgoodwin@redhat.com>
Cc: David Jeffery <dhjeffery@gmail.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC] Reduce amount of TURs sent in error recovery
Date: Mon, 11 Apr 2011 00:59:36 -0500 [thread overview]
Message-ID: <4DA298C8.9090409@cs.wisc.edu> (raw)
In-Reply-To: <4DA250C7.60904@redhat.com>
On 04/10/2011 07:52 PM, Mark Goodwin wrote:
> --- a/drivers/scsi/scsi.c
> +++ b/drivers/scsi/scsi.c
> @@ -554,7 +554,10 @@ int scsi_dispatch_cmd(struct scsi_cmnd *cmd)
> cmd->result = (DID_NO_CONNECT << 16);
> scsi_done(cmd);
> } else {
> - rtn = host->hostt->queuecommand(cmd, scsi_done);
> + if (cmd->device->sdev_state == SDEV_ZOMBIE)
> + rtn = 0; /* will timeout so err handler will run */
> + else
> + rtn = host->hostt->queuecommand(cmd, scsi_done);
> }
>
> Would we want to consider adding this to the patch set too? It will allow
> affected sites to more easily tune their timeouts and redundancy config
> (i.e. echo zombie > /sys/block/sdX/device/state to simulate a failure).
You have someting like that already in the block layer with the
io-timeout-fail sysfs setting.
prev parent reply other threads:[~2011-04-11 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 17:43 [PATCH RFC] Reduce amount of TURs sent in error recovery David Jeffery
2011-03-29 23:09 ` Mike Christie
2011-04-11 0:52 ` Mark Goodwin
2011-04-11 5:59 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA298C8.9090409@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=dhjeffery@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mgoodwin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).