From: Jens Axboe <jaxboe@fusionio.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Parag Warudkar <parag.lkml@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Linux SCSI List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS]
Date: Wed, 25 May 2011 21:02:24 +0200 [thread overview]
Message-ID: <4DDD5240.2060308@fusionio.com> (raw)
In-Reply-To: <BANLkTimZi6rPSA-1OX+ZAh3135SMpDcHKg@mail.gmail.com>
On 2011-05-25 20:55, Linus Torvalds wrote:
> On Wed, May 25, 2011 at 11:44 AM, Parag Warudkar <parag.lkml@gmail.com> wrote:
>>
>> Below patch pushes the check down to ioctl functions and hopefully should
>> cover more ioctl-on-gone-device cases by returning -ENXIO if an attempt
>> was made to submit request to a non-running device.
>
> Can we please not duplicate complicated logic like that?
>
> IOW, just make a helper function for it.
>
> That said, isn't this all *exactly* what scsi_prep_state_check() is
> supposed to check for? Why isn't that called, or if called, why isn't
> it doing the right thing?
This is before you get that far, it's actually oopsing on inserting the
request on sdev->sdev_queue that is now NULL. The prep state checking
happens when sr/sd pulls the request off the queue for processing.
--
Jens Axboe
next prev parent reply other threads:[~2011-05-25 19:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.02.1105232329040.1910@natty-nar>
2011-05-24 10:44 ` __elv_add_request OOPS Jens Axboe
2011-05-25 1:41 ` [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS] Parag Warudkar
2011-05-25 7:37 ` Jens Axboe
2011-05-25 18:44 ` Parag Warudkar
2011-05-25 18:55 ` Linus Torvalds
2011-05-25 19:02 ` Jens Axboe [this message]
2011-05-25 19:13 ` Linus Torvalds
2011-05-25 19:17 ` Jens Axboe
2011-05-25 19:52 ` Parag Warudkar
2011-05-25 20:03 ` Linus Torvalds
2011-05-25 20:18 ` Parag Warudkar
2011-05-25 20:26 ` Linus Torvalds
2011-05-25 20:42 ` Parag Warudkar
2011-05-25 20:52 ` James Bottomley
2011-05-25 23:00 ` Parag Warudkar
2011-05-25 23:14 ` Linus Torvalds
2011-05-25 23:45 ` Parag Warudkar
2011-05-25 23:52 ` Linus Torvalds
[not found] ` <1306370123.1641.76.camel@mulgrave.site>
2011-05-26 1:01 ` Linus Torvalds
2011-05-26 1:06 ` James Bottomley
2011-05-26 1:43 ` Parag Warudkar
2011-05-27 3:53 ` James Bottomley
2011-05-27 5:43 ` Jens Axboe
2011-05-27 20:21 ` James Bottomley
2011-05-28 12:42 ` Jens Axboe
2011-06-08 6:50 ` Torsten Hilbrich
2011-05-25 20:20 ` James Bottomley
2011-05-25 20:22 ` Parag Warudkar
2011-05-25 20:29 ` James Bottomley
2011-05-25 20:26 ` __elv_add_request OOPS James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDD5240.2060308@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=parag.lkml@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).