From: Ankit Jain <jankit@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: JBottomley@parallels.com, Lindar Liu <lindar_liu@usish.com>,
Xiangliang Yu <yuxiangl@marvell.com>,
linux-scsi@vger.kernel.org, Jack Wang <jack_wang@usish.com>
Subject: Re: [PATCH] libsas: export sas_alloc_task()
Date: Sat, 28 May 2011 19:24:19 +0530 [thread overview]
Message-ID: <4DE0FE8B.3090603@suse.de> (raw)
In-Reply-To: <20110528010202.13696.25504.stgit@localhost6.localdomain6>
On 05/28/2011 06:32 AM, Dan Williams wrote:
> Before isci adds a 3rd open coded user of this functionality just share
> the libsas version.
>
> Cc: Jack Wang <jack_wang@usish.com>
> Cc: Lindar Liu <lindar_liu@usish.com>
> Cc: Xiangliang Yu <yuxiangl@marvell.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/scsi/libsas/sas_init.c | 27 ++++++++++++++++++++++++++-
> drivers/scsi/mvsas/mv_sas.c | 28 +++-------------------------
> drivers/scsi/pm8001/pm8001_sas.c | 36 ++++++------------------------------
> include/scsi/libsas.h | 26 ++------------------------
> 4 files changed, 37 insertions(+), 80 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c
> index 2dc5534..408a46b 100644
> --- a/drivers/scsi/libsas/sas_init.c
> +++ b/drivers/scsi/libsas/sas_init.c
Comments in include/linux/slab.h suggest that KMEM_CACHE macro should be
used now instead of kmem_cache_create. Since you are touching this code
anyway, might as well fix that (in sas_class_init).
Thanks,
--
Ankit Jain
SUSE Labs
prev parent reply other threads:[~2011-05-28 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 1:02 [PATCH] libsas: export sas_alloc_task() Dan Williams
2011-05-28 13:54 ` Ankit Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE0FE8B.3090603@suse.de \
--to=jankit@suse.de \
--cc=JBottomley@parallels.com \
--cc=dan.j.williams@intel.com \
--cc=jack_wang@usish.com \
--cc=lindar_liu@usish.com \
--cc=linux-scsi@vger.kernel.org \
--cc=yuxiangl@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).