From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kiran Patil Subject: Re: [SCSI] tcm_fc: Adding FC_FC4 provider (tcm_fc) for FCoE target (TCM - target core) support Date: Wed, 08 Jun 2011 13:51:21 -0700 Message-ID: <4DEFE0C9.10206@intel.com> References: <201105202102.p4KL28Io025077@hera.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga01.intel.com ([192.55.52.88]:19503 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754103Ab1FHUvi (ORCPT ); Wed, 8 Jun 2011 16:51:38 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Geert Uytterhoeven Cc: Joe Eykholt , Nicholas Bellinger , "James E.J. Bottomley" , Linux Kernel Mailing List , scsi Hi Geert, Response in-line. On 6/8/2011 1:10 PM, Geert Uytterhoeven wrote: >> [SCSI] tcm_fc: Adding FC_FC4 provider (tcm_fc) for FCoE target (= TCM - target core) support >> >> This is a comprehensive patch for FC-FC4 provider. tcm_fc is a F= C-FC4 >> provider which glues target core (TCM) with Fiber channel librar= y >> (libfc). tcm_fc uses existing FC4 provider hooks from Fiber chan= nel >> library. This Fiber channel library is used by FCoE (transport -= FC >> over Ethernet) protocol driver as well. >> --- /dev/null >> +++ b/drivers/target/tcm_fc/tfc_conf.c >> +static int __init ft_init(void) >> +{ >> + if (ft_register_configfs()) >> + return -1; >> + if (fc_fc4_register_provider(FC_TYPE_FCP,&ft_prov)) { >> + ft_deregister_configfs(); >> + return -1; >> + } >> + blocking_notifier_chain_register(&fc_lport_notifier_head,&ft= _notifier); >> + fc_lport_iterate(ft_lport_add, NULL); >> + return 0; >> +} >> + >> +static void __exit ft_exit(void) >> +{ >> + blocking_notifier_chain_unregister(&fc_lport_notifier_head, >> +&ft_notifier); >> + fc_fc4_deregister_provider(FC_TYPE_FCP,&ft_prov); >> + fc_lport_iterate(ft_lport_del, NULL); >> + ft_deregister_configfs(); >> + synchronize_rcu(); >> +} >> + >> +#ifdef MODULE >> +MODULE_DESCRIPTION("FC TCM fabric driver " FT_VERSION); >> +MODULE_LICENSE("GPL"); >> +module_init(ft_init); >> +module_exit(ft_exit); >> +#endif /* MODULE */ > If CONFIG_TCM_FC=3Dy, this gives: > > | drivers/target/tcm_fc/tfc_conf.c:642: warning: =E2=80=98ft_init=E2=80= =99 defined but not used > > Shouldn't the #ifdef MODULE and #endif just be removed? Agree. Will get it fixed. > Who else initializes this module if it's builtin? > E.g. ft_register_configfs() is global, but not used outside this sour= ce file? > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linu= x-m68k.org > > In personal conversations with technical people, I call myself a hack= er. But > when I'm talking to journalists I just say "programmer" or something = like that. > -- Linus Torvalds Thanks -- KIran P. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html