From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wayne Boyer Subject: Re: [PATCH] drivers/scsi/ipr.c: reorder error handling code to include iounmap Date: Mon, 20 Jun 2011 09:47:24 -0700 Message-ID: <4DFF799C.9000102@linux.vnet.ibm.com> References: <1306851409-14963-1-git-send-email-julia@diku.dk> <4DF0EC00.9020603@linux.vnet.ibm.com> <4DF787BC.8050701@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall Cc: Brian King , kernel-janitors@vger.kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 06/15/2011 01:50 AM, Julia Lawall wrote: > On Tue, 14 Jun 2011, Brian King wrote: > >> On 06/09/2011 10:51 AM, Wayne Boyer wrote: >>> On 05/31/2011 07:16 AM, Julia Lawall wrote: >>>> From: Julia Lawall >>>> >>>> The out_msi_disable label should be before cleanup_nomem to additionally >>>> benefit from the call to iounmap. >>> >>> Yes, this is a problem. I propose the following patch instead. >> >> By removing the out_msi_disable label, if you fail initialization later >> on and goto cleanup_nomem, you will end up leaving MSI enabled when you exit >> with this patch. > > I agree. > > julia > I also agree. Please disregard my patch. -- Wayne Boyer IBM - Beaverton, Oregon LTC S/W Development (503) 578-5236, T/L 775-5236