lpfc_debugfs_dumpHBASlim_data() stack space use

public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed

* lpfc_debugfs_dumpHBASlim_data() stack space use
@ 2011-07-12 19:57 Rob Evers
  2011-07-13  2:26 ` James Smart
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Evers @ 2011-07-12 19:57 UTC (permalink / raw)
  To: linux-scsi@vger.kernel.org; +Cc: James Smart

  Hi James S.

I noticed:

static int
lpfc_debugfs_dumpHBASlim_data(struct lpfc_hba *phba, char *buf, int size)
{
         int len = 0;
         int i, off;
         uint32_t *ptr;
         char buffer[1024];


Would 'char *buffer=kmalloc()' be more appropriate here?

Rob

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: lpfc_debugfs_dumpHBASlim_data() stack space use
  2011-07-12 19:57 lpfc_debugfs_dumpHBASlim_data() stack space use Rob Evers
@ 2011-07-13  2:26 ` James Smart
  0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2011-07-13  2:26 UTC (permalink / raw)
  To: Rob Evers; +Cc: linux-scsi@vger.kernel.org

yes - something popped up with a recent change in the compiler.

The following patch addressed this issue.
http://marc.info/?l=linux-scsi&m=130655514918715&w=2

-- james s


On 7/12/2011 3:57 PM, Rob Evers wrote:
>    Hi James S.
>
> I noticed:
>
> static int
> lpfc_debugfs_dumpHBASlim_data(struct lpfc_hba *phba, char *buf, int size)
> {
>           int len = 0;
>           int i, off;
>           uint32_t *ptr;
>           char buffer[1024];
>
>
> Would 'char *buffer=kmalloc()' be more appropriate here?
>
> Rob
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-07-13  2:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-12 19:57 lpfc_debugfs_dumpHBASlim_data() stack space use Rob Evers
2011-07-13  2:26 ` James Smart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox