* [PATCH] [SCSI] ipr: Always initiate hard reset in kdump kernel
@ 2011-08-01 9:43 Anton Blanchard
2011-08-09 15:08 ` Brian King
0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2011-08-01 9:43 UTC (permalink / raw)
To: wayneb, brking, JBottomley; +Cc: linux-scsi
During kdump testing I noticed timeouts when initialising each IPR
adapter. While the driver has logic to detect an adapter in an
indeterminate state, it wasn't triggering and each adapter went
through a 5 minute timeout before finally going operational.
Some analysis showed the needs_hard_reset flag wasn't getting set.
We can check the reset_devices kernel parameter which is set by
kdump and force a full reset. This fixes the problem.
Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: <stable@kernel.org>
---
Index: linux-2.6/drivers/scsi/ipr.c
===================================================================
--- linux-2.6.orig/drivers/scsi/ipr.c 2011-07-28 13:47:17.000000000 +1000
+++ linux-2.6/drivers/scsi/ipr.c 2011-07-29 18:46:57.000000000 +1000
@@ -8812,7 +8812,7 @@ static int __devinit ipr_probe_ioa(struc
uproc = readl(ioa_cfg->regs.sense_uproc_interrupt_reg32);
if ((mask & IPR_PCII_HRRQ_UPDATED) == 0 || (uproc & IPR_UPROCI_RESET_ALERT))
ioa_cfg->needs_hard_reset = 1;
- if (interrupts & IPR_PCII_ERROR_INTERRUPTS)
+ if ((interrupts & IPR_PCII_ERROR_INTERRUPTS) || reset_devices)
ioa_cfg->needs_hard_reset = 1;
if (interrupts & IPR_PCII_IOA_UNIT_CHECKED)
ioa_cfg->ioa_unit_checked = 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [SCSI] ipr: Always initiate hard reset in kdump kernel
2011-08-01 9:43 [PATCH] [SCSI] ipr: Always initiate hard reset in kdump kernel Anton Blanchard
@ 2011-08-09 15:08 ` Brian King
0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2011-08-09 15:08 UTC (permalink / raw)
To: Anton Blanchard; +Cc: wayneb, brking, JBottomley, linux-scsi
Acked-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-09 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-01 9:43 [PATCH] [SCSI] ipr: Always initiate hard reset in kdump kernel Anton Blanchard
2011-08-09 15:08 ` Brian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox