From: Boaz Harrosh <bharrosh@panasas.com>
To: "James E.J. Bottomley" <JBottomley@parallels.com>,
Maxin B John <maxin.john@gmail.com>
Cc: rdunlap@xenotime.net, osd-dev@open-osd.org, linux-scsi@vger.kernel.org
Subject: [PATCH] osd: Kconfig remove wrong FIXME
Date: Mon, 15 Aug 2011 12:01:41 -0700 [thread overview]
Message-ID: <4E496D15.1010404@panasas.com> (raw)
In-Reply-To: <4E4968F0.9050108@panasas.com>
The OSD protocol calls for all kind of security levels that use
CRYPTO_HMAC and SH1, but the current code only supports NO_SEC,
which does not use any of these.
Remove a wrong FIXME that calls for them. Thanks Maxin for
reporting on this.
CC: "Maxin B. John" <maxin.john@gmail.com>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
drivers/scsi/osd/Kconfig | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
index 861b5ce..a070351 100644
--- a/drivers/scsi/osd/Kconfig
+++ b/drivers/scsi/osd/Kconfig
@@ -11,10 +11,6 @@
# it under the terms of the GNU General Public version 2 License as
# published by the Free Software Foundation
#
-# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
-# How is it done properly?
-#
-
config SCSI_OSD_INITIATOR
tristate "OSD-Initiator library"
depends on SCSI
--
1.7.6
next prev parent reply other threads:[~2011-08-15 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 14:27 [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library Maxin B. John
2011-08-14 23:18 ` Maxin B John
2011-08-15 18:44 ` Boaz Harrosh
2011-08-15 19:01 ` Boaz Harrosh [this message]
2011-08-25 13:15 ` [PATCH] osd: Kconfig remove wrong FIXME Maxin B John
2011-08-25 16:25 ` Boaz Harrosh
2011-08-25 13:10 ` [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library Maxin B John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E496D15.1010404@panasas.com \
--to=bharrosh@panasas.com \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=maxin.john@gmail.com \
--cc=osd-dev@open-osd.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox