From: Boaz Harrosh <bharrosh@panasas.com>
To: Maxin B John <maxin.john@gmail.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
rdunlap@xenotime.net, osd-dev@open-osd.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] osd: Kconfig remove wrong FIXME
Date: Thu, 25 Aug 2011 09:25:26 -0700 [thread overview]
Message-ID: <4E567776.5040304@panasas.com> (raw)
In-Reply-To: <CAMhs6YzUaZat4LyUJBCf8XN+OELvmbDk6bxYjbMSg7=JGEZetA@mail.gmail.com>
On 08/25/2011 06:15 AM, Maxin B John wrote:
> Hi,
>
> On Mon, Aug 15, 2011 at 10:01 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>>
>> The OSD protocol calls for all kind of security levels that use
>> CRYPTO_HMAC and SH1, but the current code only supports NO_SEC,
>> which does not use any of these.
>>
>> Remove a wrong FIXME that calls for them. Thanks Maxin for
>> reporting on this.
>>
>> CC: "Maxin B. John" <maxin.john@gmail.com>
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>> ---
>> drivers/scsi/osd/Kconfig | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
>> index 861b5ce..a070351 100644
>> --- a/drivers/scsi/osd/Kconfig
>> +++ b/drivers/scsi/osd/Kconfig
>> @@ -11,10 +11,6 @@
>> # it under the terms of the GNU General Public version 2 License as
>> # published by the Free Software Foundation
>> #
>> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
>> -# How is it done properly?
>> -#
>> -
>> config SCSI_OSD_INITIATOR
>> tristate "OSD-Initiator library"
>> depends on SCSI
>> --
>> 1.7.6
>>
>
> Adding the "Reported-by", if it's not too late:
>
> Reported-by: Maxin B. John <maxin.john@gmail.com>
>
Sure I will add it. It's not to late
Boaz
> Cheers,
> Maxin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-08-25 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 14:27 [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library Maxin B. John
2011-08-14 23:18 ` Maxin B John
2011-08-15 18:44 ` Boaz Harrosh
2011-08-15 19:01 ` [PATCH] osd: Kconfig remove wrong FIXME Boaz Harrosh
2011-08-25 13:15 ` Maxin B John
2011-08-25 16:25 ` Boaz Harrosh [this message]
2011-08-25 13:10 ` [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library Maxin B John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E567776.5040304@panasas.com \
--to=bharrosh@panasas.com \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=maxin.john@gmail.com \
--cc=osd-dev@open-osd.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox