From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH] osd: Kconfig remove wrong FIXME Date: Thu, 25 Aug 2011 09:25:26 -0700 Message-ID: <4E567776.5040304@panasas.com> References: <20110811142749.GA26109@maxin> <4E4968F0.9050108@panasas.com> <4E496D15.1010404@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from natasha.panasas.com ([67.152.220.90]:41706 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194Ab1HYQZs (ORCPT ); Thu, 25 Aug 2011 12:25:48 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Maxin B John Cc: "James E.J. Bottomley" , rdunlap@xenotime.net, osd-dev@open-osd.org, linux-scsi@vger.kernel.org On 08/25/2011 06:15 AM, Maxin B John wrote: > Hi, > > On Mon, Aug 15, 2011 at 10:01 PM, Boaz Harrosh wrote: >> >> The OSD protocol calls for all kind of security levels that use >> CRYPTO_HMAC and SH1, but the current code only supports NO_SEC, >> which does not use any of these. >> >> Remove a wrong FIXME that calls for them. Thanks Maxin for >> reporting on this. >> >> CC: "Maxin B. John" >> Signed-off-by: Boaz Harrosh >> --- >> drivers/scsi/osd/Kconfig | 4 ---- >> 1 files changed, 0 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig >> index 861b5ce..a070351 100644 >> --- a/drivers/scsi/osd/Kconfig >> +++ b/drivers/scsi/osd/Kconfig >> @@ -11,10 +11,6 @@ >> # it under the terms of the GNU General Public version 2 License as >> # published by the Free Software Foundation >> # >> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow. >> -# How is it done properly? >> -# >> - >> config SCSI_OSD_INITIATOR >> tristate "OSD-Initiator library" >> depends on SCSI >> -- >> 1.7.6 >> > > Adding the "Reported-by", if it's not too late: > > Reported-by: Maxin B. John > Sure I will add it. It's not to late Boaz > Cheers, > Maxin > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >