Re: [PATCH 1/2] alua: clarify messages when blk_execute_rq fails

[Rob Evers <revers@redhat.com>]

  On 08/30/2011 09:12 PM, Rob Evers wrote:
>  On 08/30/2011 05:37 PM, James Bottomley wrote:
>> On Tue, 2011-08-30 at 16:07 -0400, Rob Evers wrote:
>>> On 08/12/2011 05:01 PM, Rob Evers wrote:
>>>> replace numeric messages with string error messages when 
>>>> blk_execute_rq
>>>> fails.  Also add printing of sense info.
>>>>
>>>> Mike Christie suggested adding printing of sense info here
>>>>
>>>> Signed-off-by: Rob Evers<revers@redhat.com>
>>>>
>>> Hi James,
>>>
>>> Do you have any feedback on these patches?
>>>
>>> (I already noticed the 2nd patch is a reply to the first)
>>>
>>> I didn't see them in the last update of scsi-misc.
>> I don't really see any point in removing messages.
>
> "Unhandled error/sense code" can be interpreted as something going
> wrong when nothing actually went wrong.
>
> For lack of ideas that were accurate, yet not alarming, removing the 
> message
> altogether seemed like the right option.

Hi James,

Just a bit more info on these patches.

We are getting user reports that messages addressed
are causing confusion during fabric faults.

"Unhandled error code"

gets reported with no functional problems being reported.

and...

alua: rtpg failed with 10000
alua: rtpg failed with 800000

Which are cryptic.  I tried to clarify these.  Perhaps
Hannes will consider these.

I tried to address all the instances consistently even
though some are not actually being reported.

Apologies for not explaining the user reports at first.

Rob