* [PATCH] scsi: qla4xxx driver depends on NET
@ 2011-09-11 0:13 Randy Dunlap
2011-09-12 22:31 ` Vikas Chaudhary
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2011-09-11 0:13 UTC (permalink / raw)
To: scsi; +Cc: JBottomley, Linus Torvalds, Ravi Anand, Vikas Chaudhary,
iscsi-driver
From: Randy Dunlap <rdunlap@xenotime.net>
When CONFIG_NET is disabled, SCSI_QLA_ISCSI selects SCSI_ISCSI_ATTRS,
which uses network interfaces, so the build fails with multiple errors:
warning: (ISCSI_TCP && SCSI_CXGB3_ISCSI && SCSI_CXGB4_ISCSI && SCSI_QLA_ISCSI && INFINIBAND_ISER) selects SCSI_ISCSI_ATTRS which has unmet direct dependencies (SCSI && NET)
ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "sysfs_format_mac" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
so make SCSI_QLA_ISCSI also depend on NET to prevent the build errors.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Ravi Anand <ravi.anand@qlogic.com>
Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: iscsi-driver@qlogic.com
---
drivers/scsi/qla4xxx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-31-rc5.orig/drivers/scsi/qla4xxx/Kconfig
+++ lnx-31-rc5/drivers/scsi/qla4xxx/Kconfig
@@ -1,6 +1,6 @@
config SCSI_QLA_ISCSI
tristate "QLogic ISP4XXX and ISP82XX host adapter family support"
- depends on PCI && SCSI
+ depends on PCI && SCSI && NET
select SCSI_ISCSI_ATTRS
---help---
This driver supports the QLogic 40xx (ISP4XXX) and 8022 (ISP82XX)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla4xxx driver depends on NET
2011-09-11 0:13 [PATCH] scsi: qla4xxx driver depends on NET Randy Dunlap
@ 2011-09-12 22:31 ` Vikas Chaudhary
0 siblings, 0 replies; 2+ messages in thread
From: Vikas Chaudhary @ 2011-09-12 22:31 UTC (permalink / raw)
To: Randy Dunlap, scsi
Cc: JBottomley@parallels.com, Linus Torvalds, Ravi Anand,
Dept_iscsi_driver
On 10/09/11 5:13 PM, "Randy Dunlap" <rdunlap@xenotime.net> wrote:
>From: Randy Dunlap <rdunlap@xenotime.net>
>
>When CONFIG_NET is disabled, SCSI_QLA_ISCSI selects SCSI_ISCSI_ATTRS,
>which uses network interfaces, so the build fails with multiple errors:
>
>warning: (ISCSI_TCP && SCSI_CXGB3_ISCSI && SCSI_CXGB4_ISCSI &&
>SCSI_QLA_ISCSI && INFINIBAND_ISER) selects SCSI_ISCSI_ATTRS which has
>unmet direct dependencies (SCSI && NET)
>
>ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko]
>undefined!
>ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko]
>undefined!
>ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko]
>undefined!
>ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>ERROR: "sysfs_format_mac" [drivers/scsi/qla4xxx/qla4xxx.ko] undefined!
>
>so make SCSI_QLA_ISCSI also depend on NET to prevent the build errors.
>
>Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>Cc: Ravi Anand <ravi.anand@qlogic.com>
>Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
>Cc: iscsi-driver@qlogic.com
>---
> drivers/scsi/qla4xxx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>--- lnx-31-rc5.orig/drivers/scsi/qla4xxx/Kconfig
>+++ lnx-31-rc5/drivers/scsi/qla4xxx/Kconfig
>@@ -1,6 +1,6 @@
> config SCSI_QLA_ISCSI
> tristate "QLogic ISP4XXX and ISP82XX host adapter family support"
>- depends on PCI && SCSI
>+ depends on PCI && SCSI && NET
> select SCSI_ISCSI_ATTRS
> ---help---
> This driver supports the QLogic 40xx (ISP4XXX) and 8022 (ISP82XX)
Acked-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-12 22:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-11 0:13 [PATCH] scsi: qla4xxx driver depends on NET Randy Dunlap
2011-09-12 22:31 ` Vikas Chaudhary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).