Re: [PATCH] scsi: SCSI_ISCI needs to select SCSI_SAS_HOST_SMP, fixes build error

[Randy Dunlap <rdunlap@xenotime.net>]

On 09/23/2011 04:43 PM, Dan Williams wrote:
> On Fri, Sep 23, 2011 at 3:43 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> SCSI_ISCI needs to select SCSI_SAS_HOST_SMP to ensure that all
>> needed symbols are available to it.
>>
>> Fixes this build error:
>> ERROR: "try_test_sas_gpio_gp_bit" [drivers/scsi/isci/isci.ko] undefined!
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> 
> Thanks Randy!
> 
> Here's a replacement patch (also attached), that just stubs out that
> routine in the !SCSI_SAS_HOST_SMP case.

Yes, that works too.

Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> From 645ea60066251c2728197bf7a1048d885626936f Mon Sep 17 00:00:00 2001
> From: Dan Williams <dan.j.williams@intel.com>
> Date: Fri, 23 Sep 2011 16:28:53 -0700
> Subject: [PATCH] libsas: fix try_test_sas_gpio_gp_bit() build error
> 
> If the user has disabled CONFIG_SCSI_SAS_HOST_SMP then libsas drivers
> will not be receiving smp-gpio frames and do not need this lookup code.
> 
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  include/scsi/libsas.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index 44f5634..0d78bfa 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -407,7 +407,14 @@ static inline unsigned int to_sas_gpio_od(int
> device, int bit)
>  	return 3 * device + bit;
>  }
> 
> +#ifdef CONFIG_SCSI_SAS_HOST_SMP
>  int try_test_sas_gpio_gp_bit(unsigned int od, u8 *data, u8 index, u8 count);
> +#else
> +static inline int try_test_sas_gpio_gp_bit(unsigned int od, u8 *data,
> u8 index, u8 count)
> +{
> +	return -1;
> +}
> +#endif
> 
>  /* ---------- Tasks ---------- */
>  /*


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***