Re: [PATCH] scsi_io_completion: soften unhandled error and sense messages

[Hannes Reinecke <hare@suse.de>]

On 10/07/2011 12:08 AM, Rob Evers wrote:
> We are receiving reports that users are seeing error messages during
> fabric faults, but the systems are not malfunctioning.  I previously
> submitted a patch which simply removed the offending messages but
> James Bottomley rejected this as we were losing error information.
>
> This patch softens the messages such that they don't appear to
> be error indications from the user perspective.
>
> new messages suggested by Mike Christie
>
> Signed-off-by: Rob Evers<revers@redhat.com>
> ---
>   drivers/scsi/scsi_lib.c |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index fc3f168..ef2a8a1 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -920,12 +920,13 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
>   			action = ACTION_FAIL;
>   			break;
>   		default:
> -			description = "Unhandled sense code";
> +			description =
> +				"Extended sense description not available";
>   			action = ACTION_FAIL;
>   			break;
>   		}
>   	} else {
> -		description = "Unhandled error code";
> +		description = "Extended error description not available";
>   		action = ACTION_FAIL;
>   	}
>
Actually, I would prefer having this message routed via the 
scsi_logging mechanism. Then it wouldn't bother the unsuspecting 
user and we still would retain the information if scsi_logging is 
enabled.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html