[RESEND][PATCH 2/4] scsi_dh_hp_sw: Adding the match function for hp_sw device handler

[RESEND][PATCH 2/4] scsi_dh_hp_sw: Adding the match function for hp_sw device handler

[Moger, Babu]

This patch introduces the match function for hp_sw device handler.
The match function was introduced by this patch
http://www.spinics.net/lists/linux-scsi/msg54284.html

Signed-off-by: Babu Moger <babu.moger@netapp.com>
---

--- linux/drivers/scsi/device_handler/scsi_dh_hp_sw.c.orig	2011-10-31 11:25:07.000000000 -0500
+++ linux/drivers/scsi/device_handler/scsi_dh_hp_sw.c	2011-10-31 12:33:05.000000000 -0500
@@ -319,6 +319,20 @@ static const struct scsi_dh_devlist hp_s
 	{NULL, NULL},
 };
 
+static bool hp_sw_match(struct scsi_device *sdev)
+{
+	int i;
+	for (i = 0; hp_sw_dh_data_list[i].vendor; i++) {
+		if (!strncmp(sdev->vendor, hp_sw_dh_data_list[i].vendor,
+			strlen(hp_sw_dh_data_list[i].vendor)) &&
+		    !strncmp(sdev->model, hp_sw_dh_data_list[i].model,
+			strlen(hp_sw_dh_data_list[i].model))) {
+			return true;
+		}
+	}
+	return false;
+}
+
 static int hp_sw_bus_attach(struct scsi_device *sdev);
 static void hp_sw_bus_detach(struct scsi_device *sdev);
 
@@ -330,6 +344,7 @@ static struct scsi_device_handler hp_sw_
 	.detach		= hp_sw_bus_detach,
 	.activate	= hp_sw_activate,
 	.prep_fn	= hp_sw_prep_fn,
+	.match		= hp_sw_match,
 };
 
 static int hp_sw_bus_attach(struct scsi_device *sdev)

Re: [dm-devel] [RESEND][PATCH 2/4] scsi_dh_hp_sw: Adding the match function for hp_sw device handler

[Hannes Reinecke]

Hi Babu,

On 11/03/2011 04:51 PM, Moger, Babu wrote:
> This patch introduces the match function for hp_sw device handler.
> The match function was introduced by this patch
> http://www.spinics.net/lists/linux-scsi/msg54284.html
>
> Signed-off-by: Babu Moger<babu.moger@netapp.com>

Actually, the old HP MSA has a firmware update which also makes it 
ALUA capable. So we would need to add the check here, too.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [dm-devel] [RESEND][PATCH 2/4] scsi_dh_hp_sw: Adding the match function for hp_sw device handler

[Moger, Babu]

> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@suse.de]
> Sent: Friday, November 04, 2011 2:33 AM
> To: device-mapper development
> Cc: Moger, Babu; Linux SCSI Mailing list
> Subject: Re: [dm-devel] [RESEND][PATCH 2/4] scsi_dh_hp_sw: Adding the
> match function for hp_sw device handler
> 
> Hi Babu,
> 
> On 11/03/2011 04:51 PM, Moger, Babu wrote:
> > This patch introduces the match function for hp_sw device handler.
> > The match function was introduced by this patch
> > http://www.spinics.net/lists/linux-scsi/msg54284.html
> >
> > Signed-off-by: Babu Moger<babu.moger@netapp.com>
> 
> Actually, the old HP MSA has a firmware update which also makes it
> ALUA capable. So we would need to add the check here, too.

Sure.. I will add the TPGS check and resend this patch.. Thanks..

> 
> Cheers,
> 
> Hannes
> --
> Dr. Hannes Reinecke		      zSeries & Storage
> hare@suse.de			      +49 911 74053 688
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html