Re: [PATCH] Remove 'unhandled error code' messages

[Hannes Reinecke <hare@suse.de>]

On 11/10/2011 03:55 PM, James Bottomley wrote:
> On Thu, 2011-11-10 at 15:12 +0100, Hannes Reinecke wrote:
>> scsi_io_completion() tries to take some action based on
>> the command result and sense code. It also displays
>> 'unhandled error code' or 'unhandled sense code' in case
>> no special handling was found.
>> This serves as an additional source of confusion to
>> the unsuspecting user, as the message in fact means
>> 'everything okay, no special casing required',
>> and not 'oh gosh, something has happened and the system
>> couldn't deal with it'.
>
> It means we're just about to fail the command with an error.  That's not
> really an everything ok case.
>
> Sometimes, you're right, this is the correct thing to do silently, but
> often it's not.  So, same question to you as to Rob: What are the
> circumstances you want silent failure for and can you special case them?
>
The whole point here is: It's not silent, even when the 
'description' is not set.

	switch (action) {
	case ACTION_FAIL:
		/* Give up and fail the remainder of the request */
		scsi_release_buffers(cmd);
		if (!(req->cmd_flags & REQ_QUIET)) {
			if (description)
				scmd_printk(KERN_INFO, cmd, "%s\n",
					    description);
			scsi_print_result(cmd);
			if (driver_byte(result) & DRIVER_SENSE)
				scsi_print_sense("", cmd);
			scsi_print_command(cmd);
		}
		if (blk_end_request_err(req, error))
			scsi_requeue_command(q, cmd);
		else
			scsi_next_command(cmd);
		break;

So the decoded result and sense code is printed always, regardless 
of the 'description'.
The 'description' just tells us if there are special
circumstances. And as we didn't do anything special
we should print anything here.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html