From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] block: Revert "[SCSI] genhd: add a new attribute "alias" in gendisk" Date: Thu, 10 Nov 2011 16:21:49 -0500 Message-ID: <4EBC406D.8010404@garzik.org> References: <20111109162512.GB1260@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111109162512.GB1260@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Tejun Heo Cc: Jens Axboe , "James E.J. Bottomley" , Nao Nishijima , Kay Sievers , Greg Kroah-Hartman , Alan Cox , Al Viro , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 11/09/2011 11:25 AM, Tejun Heo wrote: > This reverts commit a72c5e5eb738033938ab30d6a634b74d1d060f10. > > The commit introduced alias for block devices which is intended to be > used during logging although actual usage hasn't been committed yet. > This approach adds very limited benefit (raw log might be easier to > follow) which can be trivially implemented in userland but has a lot > of problems. > > It is much worse than netif renames because it doesn't rename the > actual device but just adds conveninence name which isn't used > universally or enforced. Everything internal including device lookup > and sysfs still uses the internal name and nothing prevents two > devices from using conflicting alias - ie. sda can have sdb as its > alias. > > This has been nacked by people working on device driver core, block > layer and kernel-userland interface and shouldn't have been > upstreamed. Revert it. > > http://thread.gmane.org/gmane.linux.kernel/1155104 > http://thread.gmane.org/gmane.linux.scsi/68632 > http://thread.gmane.org/gmane.linux.scsi/69776 > > Signed-off-by: Tejun Heo > Cc: Jens Axboe > Cc: "James E.J. Bottomley" > Cc: Nao Nishijima > Cc: Kay Sievers > Cc: Greg Kroah-Hartman > Cc: Alan Cox > Cc: Al Viro Acked-by: Jeff Garzik