From: Mike Christie <michaelc@cs.wisc.edu>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org, James Bottomley <jbottomley@parallels.com>
Subject: Re: [PATCH] iscsi_ibft: Display iBFT signature in sysfs
Date: Wed, 30 Nov 2011 13:41:47 -0600 [thread overview]
Message-ID: <4ED686FB.6060308@cs.wisc.edu> (raw)
In-Reply-To: <1322662228-51255-1-git-send-email-hare@suse.de>
On 11/30/2011 08:10 AM, Hannes Reinecke wrote:
> Broadcom iSCSI offload cards use the signature 'BIFT' to signal
> that iSCSI offload is in use. This patch exports the iBFT signature
> to sysfs so that userspace can enable iSCSI offloading here.
Seems useful and ok to export.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Note that you should not need this for the iscsi tools though. The iscsi
tools in git already figure this out for all drivers if you compile with
OFFLOAD_BOOT_SUPPORTED set. Basically, if the MAC address in the
firmware ibft/iscsi_boot dirs/info is the same as one in the
/sys/class/iscsi_host dir then it is offload. For broadcom when you
enable hba mode it puts the offloaded MAC address in ibft. If hba mode
is not enabled then the MAC is the normal networking card port's MAC (in
this case iscsi tools will just do iscsi_tcp over bnx2x/bnx2).
prev parent reply other threads:[~2011-11-30 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 14:10 [PATCH] iscsi_ibft: Display iBFT signature in sysfs Hannes Reinecke
2011-11-30 19:41 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED686FB.6060308@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).