From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
target-devel <target-devel@vger.kernel.org>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>,
Roland Dreier <roland@purestorage.com>,
Joern Engel <joern@logfs.org>,
James Bottomley <JBottomley@Parallels.com>
Subject: Re: [PATCH] qla2xxx: Don't memset buffer unless debug level is enabled
Date: Thu, 01 Dec 2011 09:12:27 +0100 [thread overview]
Message-ID: <4ED736EB.4090201@linutronix.de> (raw)
In-Reply-To: <1322690639-20756-1-git-send-email-nab@linux-iscsi.org>
On 11/30/2011 11:03 PM, Nicholas A. Bellinger wrote:
> diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
> index 07372de..cc32ec8 100644
> --- a/drivers/scsi/qla2xxx/qla_dbg.c
> +++ b/drivers/scsi/qla2xxx/qla_dbg.c
> @@ -1676,11 +1676,11 @@ ql_dbg(uint32_t level, scsi_qla_host_t *vha, int32_t id, char *msg, ...) {
> uint32_t len;
> struct pci_dev *pdev = NULL;
>
> - memset(pbuf, 0, QL_DBG_BUF_LEN);
> -
> va_start(ap, msg);
>
> if ((level& ql2xextended_error_logging) == level) {
> + memset(pbuf, 0, QL_DBG_BUF_LEN);
> +
512bytes on the stack is brave. Anyway, why do you memset the whole
buffer? As far the string processing is concerned, setting the first
byte to zero is enough.
Sebastian
next prev parent reply other threads:[~2011-12-01 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 22:03 [PATCH] qla2xxx: Don't memset buffer unless debug level is enabled Nicholas A. Bellinger
2011-11-30 22:33 ` Chad Dupuis
2011-12-01 8:12 ` Sebastian Andrzej Siewior [this message]
2011-12-01 9:21 ` Nicholas A. Bellinger
2011-12-01 18:01 ` Chad Dupuis
2011-12-01 18:07 ` James Bottomley
2011-12-01 18:43 ` Chad Dupuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED736EB.4090201@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=JBottomley@Parallels.com \
--cc=andrew.vasquez@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).