* [PATCH] scsi_dh_rdac: Fix error path
@ 2011-11-18 0:44 Richard Weinberger
2011-11-18 14:34 ` Moger, Babu
0 siblings, 1 reply; 4+ messages in thread
From: Richard Weinberger @ 2011-11-18 0:44 UTC (permalink / raw)
To: JBottomley
Cc: Babu.moger, Somasundaram.Krishnasamy, yanling.qi, linux-scsi,
linux-kernel, Richard Weinberger
If create_singlethread_workqueue() failes, rdac_init should fail too.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/scsi/device_handler/scsi_dh_rdac.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c
index 1d31279..2802394 100644
--- a/drivers/scsi/device_handler/scsi_dh_rdac.c
+++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
@@ -934,6 +934,8 @@ static int __init rdac_init(void)
if (!kmpath_rdacd) {
scsi_unregister_device_handler(&rdac_dh);
printk(KERN_ERR "kmpath_rdacd creation failed.\n");
+
+ r = -EINVAL;
}
done:
return r;
--
1.7.7.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi_dh_rdac: Fix error path
2011-11-18 0:44 [PATCH] scsi_dh_rdac: Fix error path Richard Weinberger
@ 2011-11-18 14:34 ` Moger, Babu
2011-12-18 14:42 ` Richard Weinberger
0 siblings, 1 reply; 4+ messages in thread
From: Moger, Babu @ 2011-11-18 14:34 UTC (permalink / raw)
To: Richard Weinberger, JBottomley
Cc: Somasundaram.Krishnasamy, yanling.qi, linux-scsi, linux-kernel
Looks good to me..
> -----Original Message-----
> From: Richard Weinberger [mailto:richard@nod.at]
> Sent: Thursday, November 17, 2011 6:44 PM
> To: JBottomley@parallels.com
> Cc: Moger, Babu; Somasundaram.Krishnasamy@lsi.com; yanling.qi@lsi.com;
> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Richard
> Weinberger
> Subject: [PATCH] scsi_dh_rdac: Fix error path
>
> If create_singlethread_workqueue() failes, rdac_init should fail too.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/scsi/device_handler/scsi_dh_rdac.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c
> b/drivers/scsi/device_handler/scsi_dh_rdac.c
> index 1d31279..2802394 100644
> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
> @@ -934,6 +934,8 @@ static int __init rdac_init(void)
> if (!kmpath_rdacd) {
> scsi_unregister_device_handler(&rdac_dh);
> printk(KERN_ERR "kmpath_rdacd creation failed.\n");
> +
> + r = -EINVAL;
> }
> done:
> return r;
> --
> 1.7.7.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi_dh_rdac: Fix error path
2011-11-18 14:34 ` Moger, Babu
@ 2011-12-18 14:42 ` Richard Weinberger
2012-01-09 22:13 ` Mike Snitzer
0 siblings, 1 reply; 4+ messages in thread
From: Richard Weinberger @ 2011-12-18 14:42 UTC (permalink / raw)
To: Moger, Babu
Cc: JBottomley, Somasundaram.Krishnasamy, yanling.qi, linux-scsi,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
Am 18.11.2011 15:34, schrieb Moger, Babu:
> Looks good to me..
>
>> -----Original Message-----
>> From: Richard Weinberger [mailto:richard@nod.at]
>> Sent: Thursday, November 17, 2011 6:44 PM
>> To: JBottomley@parallels.com
>> Cc: Moger, Babu; Somasundaram.Krishnasamy@lsi.com; yanling.qi@lsi.com;
>> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Richard
>> Weinberger
>> Subject: [PATCH] scsi_dh_rdac: Fix error path
>>
>> If create_singlethread_workqueue() failes, rdac_init should fail too.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/scsi/device_handler/scsi_dh_rdac.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c
>> b/drivers/scsi/device_handler/scsi_dh_rdac.c
>> index 1d31279..2802394 100644
>> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
>> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
>> @@ -934,6 +934,8 @@ static int __init rdac_init(void)
>> if (!kmpath_rdacd) {
>> scsi_unregister_device_handler(&rdac_dh);
>> printk(KERN_ERR "kmpath_rdacd creation failed.\n");
>> +
>> + r = -EINVAL;
>> }
>> done:
>> return r;
>> --
>> 1.7.7.3
>
James,
can you please pickup this patch?
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi_dh_rdac: Fix error path
2011-12-18 14:42 ` Richard Weinberger
@ 2012-01-09 22:13 ` Mike Snitzer
0 siblings, 0 replies; 4+ messages in thread
From: Mike Snitzer @ 2012-01-09 22:13 UTC (permalink / raw)
To: Richard Weinberger
Cc: Moger, Babu, JBottomley, Somasundaram.Krishnasamy, yanling.qi,
linux-scsi, linux-kernel
On Sun, Dec 18, 2011 at 9:42 AM, Richard Weinberger <richard@nod.at> wrote:
> Am 18.11.2011 15:34, schrieb Moger, Babu:
>> Looks good to me..
>>
>>> -----Original Message-----
>>> From: Richard Weinberger [mailto:richard@nod.at]
>>> Sent: Thursday, November 17, 2011 6:44 PM
>>> To: JBottomley@parallels.com
>>> Cc: Moger, Babu; Somasundaram.Krishnasamy@lsi.com; yanling.qi@lsi.com;
>>> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Richard
>>> Weinberger
>>> Subject: [PATCH] scsi_dh_rdac: Fix error path
>>>
>>> If create_singlethread_workqueue() failes, rdac_init should fail too.
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> drivers/scsi/device_handler/scsi_dh_rdac.c | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c
>>> b/drivers/scsi/device_handler/scsi_dh_rdac.c
>>> index 1d31279..2802394 100644
>>> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
>>> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
>>> @@ -934,6 +934,8 @@ static int __init rdac_init(void)
>>> if (!kmpath_rdacd) {
>>> scsi_unregister_device_handler(&rdac_dh);
>>> printk(KERN_ERR "kmpath_rdacd creation failed.\n");
>>> +
>>> + r = -EINVAL;
>>> }
>>> done:
>>> return r;
>>> --
>>> 1.7.7.3
>>
>
> James,
>
> can you please pickup this patch?
James, was this the one that you said was overlooked?
In any case, please apply, and for good measure:
Acked-by: Mike Snitzer <snitzer@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-09 22:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 0:44 [PATCH] scsi_dh_rdac: Fix error path Richard Weinberger
2011-11-18 14:34 ` Moger, Babu
2011-12-18 14:42 ` Richard Weinberger
2012-01-09 22:13 ` Mike Snitzer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).