* [PATCH 02/08] [SCSI] mpt2sas : Increase max transfer support from 4MB to 16MB
@ 2011-12-01 2:22 nagalakshmi.nandigama
2011-12-20 16:16 ` Tomas Henzl
0 siblings, 1 reply; 3+ messages in thread
From: nagalakshmi.nandigama @ 2011-12-01 2:22 UTC (permalink / raw)
To: linux-scsi, kashyap.desai, Nagalakshmi.Nandigama, Sathya.Prakash,
Eric.Moore
Cc: JBottomley
Increase max transfer support from 4MB to 16MB.
This is done by changing the shost->max_sector from 8192 to 32767
Signed-off-by: Nagalakshmi Nandigama <nagalakshmi.nandigama@lsi.com>
---
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
index 8df4095..97f0997 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
@@ -100,7 +100,7 @@ MODULE_PARM_DESC(logging_level, " bits for enabling additional logging info "
static ushort max_sectors = 0xFFFF;
module_param(max_sectors, ushort, 0);
-MODULE_PARM_DESC(max_sectors, "max sectors, range 64 to 8192 default=8192");
+MODULE_PARM_DESC(max_sectors, "max sectors, range 64 to 32767 default=32767");
/* scsi-mid layer global parmeter is max_report_luns, which is 511 */
#define MPT2SAS_MAX_LUN (16895)
@@ -7449,7 +7449,7 @@ static struct scsi_host_template scsih_driver_template = {
.can_queue = 1,
.this_id = -1,
.sg_tablesize = MPT2SAS_SG_DEPTH,
- .max_sectors = 8192,
+ .max_sectors = 32767,
.cmd_per_lun = 7,
.use_clustering = ENABLE_CLUSTERING,
.shost_attrs = mpt2sas_host_attrs,
@@ -7990,11 +7990,11 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
printk(MPT2SAS_WARN_FMT "Invalid value %d passed "
"for max_sectors, range is 64 to 8192. Assigning "
"value of 64.\n", ioc->name, max_sectors);
- } else if (max_sectors > 8192) {
- shost->max_sectors = 8192;
+ } else if (max_sectors > 32767) {
+ shost->max_sectors = 32767;
printk(MPT2SAS_WARN_FMT "Invalid value %d passed "
"for max_sectors, range is 64 to 8192. Assigning "
- "default value of 8192.\n", ioc->name,
+ "default value of 32767.\n", ioc->name,
max_sectors);
} else {
shost->max_sectors = max_sectors & 0xFFFE;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 02/08] [SCSI] mpt2sas : Increase max transfer support from 4MB to 16MB
2011-12-01 2:22 [PATCH 02/08] [SCSI] mpt2sas : Increase max transfer support from 4MB to 16MB nagalakshmi.nandigama
@ 2011-12-20 16:16 ` Tomas Henzl
2011-12-22 3:37 ` Nandigama, Nagalakshmi
0 siblings, 1 reply; 3+ messages in thread
From: Tomas Henzl @ 2011-12-20 16:16 UTC (permalink / raw)
To: nagalakshmi.nandigama
Cc: linux-scsi, kashyap.desai, Sathya.Prakash, Eric.Moore, JBottomley
On 12/01/2011 03:22 AM, nagalakshmi.nandigama@lsi.com wrote:
> Increase max transfer support from 4MB to 16MB.
> This is done by changing the shost->max_sector from 8192 to 32767
>
> Signed-off-by: Nagalakshmi Nandigama <nagalakshmi.nandigama@lsi.com>
> ---
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index 8df4095..97f0997 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -100,7 +100,7 @@ MODULE_PARM_DESC(logging_level, " bits for enabling additional logging info "
>
> static ushort max_sectors = 0xFFFF;
> module_param(max_sectors, ushort, 0);
> -MODULE_PARM_DESC(max_sectors, "max sectors, range 64 to 8192 default=8192");
> +MODULE_PARM_DESC(max_sectors, "max sectors, range 64 to 32767 default=32767");
>
> /* scsi-mid layer global parmeter is max_report_luns, which is 511 */
> #define MPT2SAS_MAX_LUN (16895)
> @@ -7449,7 +7449,7 @@ static struct scsi_host_template scsih_driver_template = {
> .can_queue = 1,
> .this_id = -1,
> .sg_tablesize = MPT2SAS_SG_DEPTH,
> - .max_sectors = 8192,
> + .max_sectors = 32767,
> .cmd_per_lun = 7,
> .use_clustering = ENABLE_CLUSTERING,
> .shost_attrs = mpt2sas_host_attrs,
> @@ -7990,11 +7990,11 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> printk(MPT2SAS_WARN_FMT "Invalid value %d passed "
> "for max_sectors, range is 64 to 8192. Assigning "
> "value of 64.\n", ioc->name, max_sectors);
> - } else if (max_sectors > 8192) {
> - shost->max_sectors = 8192;
> + } else if (max_sectors > 32767) {
> + shost->max_sectors = 32767;
> printk(MPT2SAS_WARN_FMT "Invalid value %d passed "
> "for max_sectors, range is 64 to 8192. Assigning "
I think you wanted to change the text above "is 64 to 8192" to "is 64 to 32767" too.
That is clearly not so important and can wait for the next patch.
> - "default value of 8192.\n", ioc->name,
> + "default value of 32767.\n", ioc->name,
> max_sectors);
> } else {
> shost->max_sectors = max_sectors & 0xFFFE;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH 02/08] [SCSI] mpt2sas : Increase max transfer support from 4MB to 16MB
2011-12-20 16:16 ` Tomas Henzl
@ 2011-12-22 3:37 ` Nandigama, Nagalakshmi
0 siblings, 0 replies; 3+ messages in thread
From: Nandigama, Nagalakshmi @ 2011-12-22 3:37 UTC (permalink / raw)
To: Tomas Henzl
Cc: linux-scsi@vger.kernel.org, Desai, Kashyap, Prakash, Sathya,
Moore, Eric, JBottomley@parallels.com
Thank you for pointing out. Will correct it in the next patches.
Regards,
Nagalakshmi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Tuesday, December 20, 2011 9:46 PM
To: Nandigama, Nagalakshmi
Cc: linux-scsi@vger.kernel.org; Desai, Kashyap; Prakash, Sathya; Moore, Eric; JBottomley@parallels.com
Subject: Re: [PATCH 02/08] [SCSI] mpt2sas : Increase max transfer support from 4MB to 16MB
On 12/01/2011 03:22 AM, nagalakshmi.nandigama@lsi.com wrote:
> Increase max transfer support from 4MB to 16MB.
> This is done by changing the shost->max_sector from 8192 to 32767
>
> Signed-off-by: Nagalakshmi Nandigama <nagalakshmi.nandigama@lsi.com>
> ---
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index 8df4095..97f0997 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -100,7 +100,7 @@ MODULE_PARM_DESC(logging_level, " bits for enabling additional logging info "
>
> static ushort max_sectors = 0xFFFF;
> module_param(max_sectors, ushort, 0);
> -MODULE_PARM_DESC(max_sectors, "max sectors, range 64 to 8192 default=8192");
> +MODULE_PARM_DESC(max_sectors, "max sectors, range 64 to 32767 default=32767");
>
> /* scsi-mid layer global parmeter is max_report_luns, which is 511 */
> #define MPT2SAS_MAX_LUN (16895)
> @@ -7449,7 +7449,7 @@ static struct scsi_host_template scsih_driver_template = {
> .can_queue = 1,
> .this_id = -1,
> .sg_tablesize = MPT2SAS_SG_DEPTH,
> - .max_sectors = 8192,
> + .max_sectors = 32767,
> .cmd_per_lun = 7,
> .use_clustering = ENABLE_CLUSTERING,
> .shost_attrs = mpt2sas_host_attrs,
> @@ -7990,11 +7990,11 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> printk(MPT2SAS_WARN_FMT "Invalid value %d passed "
> "for max_sectors, range is 64 to 8192. Assigning "
> "value of 64.\n", ioc->name, max_sectors);
> - } else if (max_sectors > 8192) {
> - shost->max_sectors = 8192;
> + } else if (max_sectors > 32767) {
> + shost->max_sectors = 32767;
> printk(MPT2SAS_WARN_FMT "Invalid value %d passed "
> "for max_sectors, range is 64 to 8192. Assigning "
I think you wanted to change the text above "is 64 to 8192" to "is 64 to 32767" too.
That is clearly not so important and can wait for the next patch.
> - "default value of 8192.\n", ioc->name,
> + "default value of 32767.\n", ioc->name,
> max_sectors);
> } else {
> shost->max_sectors = max_sectors & 0xFFFE;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-22 3:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-01 2:22 [PATCH 02/08] [SCSI] mpt2sas : Increase max transfer support from 4MB to 16MB nagalakshmi.nandigama
2011-12-20 16:16 ` Tomas Henzl
2011-12-22 3:37 ` Nandigama, Nagalakshmi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox