From: Mike Christie <michaelc@cs.wisc.edu>
To: Xi Wang <xi.wang@gmail.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] iscsi_tcp: bound max_r2t in iscsi_sw_tcp_conn_set_param()
Date: Wed, 04 Jan 2012 01:16:57 -0600 [thread overview]
Message-ID: <4F03FCE9.1090603@cs.wisc.edu> (raw)
In-Reply-To: <260F336C-1C68-4DDE-9FFB-094F7AEFB3C8@gmail.com>
On 01/04/2012 12:36 AM, Xi Wang wrote:
> On Jan 2, 2012, at 9:18 AM, Xi Wang wrote:
>> On Jan 2, 2012, at 2:05 AM, Mike Christie wrote:
>>> What about the attached patch? It also fixes cxgb*i.
>>> <0001-libiscsi_tcp-fix-max_r2t-manipulation.patch>
>>
>> Looks good to me. Thanks!
>
> BTW, should max_r2t be in the range 1..65535 according to RFC 3720?
Yeah.
> Using ushort seems to limit the upper bound to 32768, though probably
> no one wants to set it to such a large value.
I thought short was 32767 and ushort was 65535. Is a short like long
where it is different on different archs?
next prev parent reply other threads:[~2012-01-04 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-31 22:01 [PATCH] iscsi_tcp: bound max_r2t in iscsi_sw_tcp_conn_set_param() Xi Wang
2012-01-02 7:05 ` Mike Christie
2012-01-02 14:18 ` Xi Wang
2012-01-04 6:36 ` Xi Wang
2012-01-04 7:16 ` Mike Christie [this message]
2012-01-04 7:12 ` Xi Wang
2012-02-09 16:04 ` Greg KH
2012-02-09 18:04 ` Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F03FCE9.1090603@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=stable@vger.kernel.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox