From: Hannes Reinecke <hare@suse.de>
To: Rob Evers <revers@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] delay transition requeues for 2 seconds - alua
Date: Thu, 12 Jan 2012 10:43:47 +0100 [thread overview]
Message-ID: <4F0EAB53.7020404@suse.de> (raw)
In-Reply-To: <1325618414-26992-1-git-send-email-revers@redhat.com>
On 01/03/2012 08:20 PM, Rob Evers wrote:
> From: Rob Evers <revers@redhat.com>
>
> When alua targets are transitioning, the scsi midlayer retry mechanism
> continuously retries the scsi commands that are returning with not ready
> transitioning status. The target is not capable of handling the
> commands for time on the order of several seconds during these transistions.
>
> This patch delays the device queue for 2 seconds, which is in the same
> order of aas transition time.
>
> Also, handle all other cases where ADD_TO_MLQUEUE_DELAY could be returned
> instead of ADD_TO_MLQUEUE as if ADD_TO_MLQUEUE were being returned.
>
> Problem found by array partner testing
>
> change MLQUEUE_DEV_DLY_RTY to MLQUEUE_DELAYED_RETRY
>
I have been working on a different solution, whic
> Signed-off-by: Rob Evers <revers@redhat.com>
> ---
> drivers/scsi/device_handler/scsi_dh_alua.c | 7 ++++---
> drivers/scsi/scsi.c | 3 +++
> drivers/scsi/scsi_error.c | 1 +
> drivers/scsi/scsi_lib.c | 9 ++++++++-
> include/scsi/scsi.h | 12 +++++++-----
> 5 files changed, 23 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 4ef0212..33b8df7 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -233,7 +233,7 @@ static void stpg_endio(struct request *req, int error)
> goto done;
> }
> err = alua_check_sense(h->sdev, &sense_hdr);
> - if (err == ADD_TO_MLQUEUE) {
> + if (err == ADD_TO_MLQUEUE || err == ADD_TO_MLQUEUE_DELAY) {
> err = SCSI_DH_RETRY;
> goto done;
> }
> @@ -443,7 +443,7 @@ static int alua_check_sense(struct scsi_device *sdev,
> /*
> * LUN Not Accessible - ALUA state transition
> */
> - return ADD_TO_MLQUEUE;
> + return ADD_TO_MLQUEUE_DELAY;
> if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0b)
> /*
> * LUN Not Accessible -- Target port in standby state
> @@ -521,7 +521,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_dh_data *h)
> return SCSI_DH_IO;
>
> err = alua_check_sense(sdev, &sense_hdr);
> - if (err == ADD_TO_MLQUEUE && time_before(jiffies, expiry))
> + if ((err == ADD_TO_MLQUEUE || err == ADD_TO_MLQUEUE_DELAY) &&
> + time_before(jiffies, expiry))
> goto retry;
> sdev_printk(KERN_INFO, sdev,
> "%s: rtpg sense code %02x/%02x/%02x\n",
Actually, this doesn't help if the RTPG command returns with the
mentioned error; then you'll just continue flooding the array with
RTPG commands. You'll need to delay the RTPG commands, too.
I'll be sending an updated patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-12 9:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 19:20 [PATCH] delay transition requeues for 2 seconds - alua Rob Evers
2012-01-07 15:06 ` Rob Evers
2012-04-25 22:16 ` Rob Evers
2012-01-12 9:43 ` Hannes Reinecke [this message]
2012-01-12 17:03 ` Rob Evers
2012-01-12 21:23 ` Hannes Reinecke
2012-01-12 19:54 ` Mike Christie
2012-01-12 19:59 ` Mike Christie
2012-01-12 22:13 ` Hannes Reinecke
2012-01-13 17:51 ` Rob Evers
2012-02-10 20:04 ` Rob Evers
-- strict thread matches above, loose matches on Subject: below --
2011-12-13 22:40 Rob Evers
2011-12-20 15:41 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0EAB53.7020404@suse.de \
--to=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=revers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).