* [PATCH] mpt2sas: add missing allocation check
@ 2012-02-13 17:29 Tomas Henzl
2012-02-14 4:04 ` Nandigama, Nagalakshmi
0 siblings, 1 reply; 2+ messages in thread
From: Tomas Henzl @ 2012-02-13 17:29 UTC (permalink / raw)
To: 'linux-scsi@vger.kernel.org'
Cc: Desai, Kashyap, Nandigama, Nagalakshmi, Stanislaw Gruszka
The __get_free_pages can fail, so the return value should be checked.
Spotted thanks to Stanislaw.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 0b2c955..590e1a1 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -2575,6 +2575,11 @@ _base_allocate_memory_pools(struct MPT2SAS_ADAPTER *ioc, int sleep_flag)
ioc->chain_lookup = (struct chain_tracker *)__get_free_pages(
GFP_KERNEL, ioc->chain_pages);
+ if (!ioc->chain_lookup) {
+ printk(MPT2SAS_ERR_FMT "chain_lookup: get_free_pages failed, "
+ "sz(%d)\n", ioc->name, (int)sz);
+ goto out;
+ }
ioc->chain_dma_pool = pci_pool_create("chain pool", ioc->pdev,
ioc->request_sz, 16, 0);
if (!ioc->chain_dma_pool) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] mpt2sas: add missing allocation check
2012-02-13 17:29 [PATCH] mpt2sas: add missing allocation check Tomas Henzl
@ 2012-02-14 4:04 ` Nandigama, Nagalakshmi
0 siblings, 0 replies; 2+ messages in thread
From: Nandigama, Nagalakshmi @ 2012-02-14 4:04 UTC (permalink / raw)
To: Tomas Henzl, 'linux-scsi@vger.kernel.org'
Cc: Desai, Kashyap, Stanislaw Gruszka
This patch seem to be fine. Please consider this patch as Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Regards,
Nagalakshmi
-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com]
Sent: Monday, February 13, 2012 11:00 PM
To: 'linux-scsi@vger.kernel.org'
Cc: Desai, Kashyap; Nandigama, Nagalakshmi; Stanislaw Gruszka
Subject: [PATCH] mpt2sas: add missing allocation check
The __get_free_pages can fail, so the return value should be checked.
Spotted thanks to Stanislaw.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 0b2c955..590e1a1 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -2575,6 +2575,11 @@ _base_allocate_memory_pools(struct MPT2SAS_ADAPTER *ioc, int sleep_flag)
ioc->chain_lookup = (struct chain_tracker *)__get_free_pages(
GFP_KERNEL, ioc->chain_pages);
+ if (!ioc->chain_lookup) {
+ printk(MPT2SAS_ERR_FMT "chain_lookup: get_free_pages failed, "
+ "sz(%d)\n", ioc->name, (int)sz);
+ goto out;
+ }
ioc->chain_dma_pool = pci_pool_create("chain pool", ioc->pdev,
ioc->request_sz, 16, 0);
if (!ioc->chain_dma_pool) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-14 4:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-13 17:29 [PATCH] mpt2sas: add missing allocation check Tomas Henzl
2012-02-14 4:04 ` Nandigama, Nagalakshmi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox