From: Mike Christie <michaelc@cs.wisc.edu>
To: vikas.chaudhary@qlogic.com
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
ravi.anand@qlogic.com, lalit.chandivade@qlogic.com
Subject: Re: [PATCH 10/11] qla4xxx: Added ping support
Date: Mon, 05 Mar 2012 20:49:37 -0600 [thread overview]
Message-ID: <4F557B41.5010703@cs.wisc.edu> (raw)
In-Reply-To: <1329138050-1042-11-git-send-email-vikas.chaudhary@qlogic.com>
On 02/13/2012 07:00 AM, vikas.chaudhary@qlogic.com wrote:
> +
> + if (mbox_sts_entry->out_mbox[0] == MBOX_STS_COMMAND_COMPLETE)
> + status = QLA_SUCCESS;
> + else
> + status = QLA_ERROR;
> +
> + data_size = sizeof(mbox_sts_entry->out_mbox);
> +
> + qla4xxx_post_ping_evt_work(ha, status, mrb->pid, data_size,
> + (uint8_t *) mbox_sts_entry->out_mbox);
> + break;
> +
Not sure what I was thinking. This is not going to work.
We are not going to pass back vendor specific values, and then have
multiple decoders in userspace.
What are you trying to pass back up to userspace? Can you add a enum or
defines for some common error values? We can also pass back vendor
specific info, but we have to also have some common error cls info or it
is completely useless to other apps.
And, can we get more info that if it failed or not?
next prev parent reply other threads:[~2012-03-06 2:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 13:00 [PATCH 00/11] qla4xxx: Update for scsi-misc vikas.chaudhary
2012-02-13 13:00 ` [PATCH 01/11] qla4xxx: Remove unused code vikas.chaudhary
2012-02-13 13:00 ` [PATCH 02/11] qla4xxx: Fix un-necessary delay on invalid DDB vikas.chaudhary
2012-02-13 13:00 ` [PATCH 03/11] qla4xxx: Fix verify boot idx correctly vikas.chaudhary
2012-02-13 13:00 ` [PATCH 04/11] qla4xxx: Modified debug log messages for boot info vikas.chaudhary
2012-02-13 13:00 ` [PATCH 05/11] qla4xxx: Remove un-necessary print statment vikas.chaudhary
2012-02-13 13:00 ` [PATCH 06/11] qla4xxx: Proper detection of firmware abort error code for ISP82xx vikas.chaudhary
2012-02-13 13:00 ` [PATCH 07/11] scsi_transport_iscsi: added support for host event vikas.chaudhary
2012-02-13 13:00 ` [PATCH 09/11] iscsi_transport: Added Ping support vikas.chaudhary
2012-02-21 21:55 ` Or Gerlitz
2012-02-21 22:33 ` Mike Christie
2012-02-21 22:39 ` Or Gerlitz
2012-02-21 22:54 ` Ravi Anand
2012-02-21 22:58 ` Mike Christie
2012-02-13 13:00 ` [PATCH 10/11] qla4xxx: Added ping support vikas.chaudhary
2012-03-06 2:49 ` Mike Christie [this message]
2012-03-06 12:26 ` Vikas Chaudhary
2012-02-13 13:00 ` [PATCH 11/11] qla4xxx: Update driver version to 5.02.00-k14 vikas.chaudhary
2012-02-15 7:00 ` [PATCH 00/11] qla4xxx: Update for scsi-misc Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F557B41.5010703@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jbottomley@parallels.com \
--cc=lalit.chandivade@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).