linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
	Stanislaw Gruszka <sgruszka@redhat.com>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH] block: Make blk_drain_queue() work for stopped queues
Date: Sun, 18 Mar 2012 13:18:21 +0000	[thread overview]
Message-ID: <4F65E09D.6010600@acm.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

All queued requests must be processed eventually. Hence make sure
that blk_drain_queue() drains the queue even if the queue is in the
stopped state. This patch makes it safe to invoke blk_cleanup_queue()
on a stopped queue.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Tejun Heo <tj@kernel.org>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: stable@vger.kernel.org
---
 block/blk-core.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 3a78b00..bdcec86 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -300,10 +300,8 @@ EXPORT_SYMBOL(blk_sync_queue);
  */
 void __blk_run_queue(struct request_queue *q)
 {
-	if (unlikely(blk_queue_stopped(q)))
-		return;
-
-	q->request_fn(q);
+	if (!blk_queue_stopped(q) || blk_queue_dead(q))
+		q->request_fn(q);
 }
 EXPORT_SYMBOL(__blk_run_queue);
 -- 1.7.7



[-- Attachment #2: Attached Message Part --]
[-- Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2012-03-18 13:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-18 13:18 Bart Van Assche [this message]
2012-03-18 15:57 ` [PATCH] block: Make blk_drain_queue() work for stopped queues Tejun Heo
2012-03-18 19:47   ` Bart Van Assche
2012-03-19  7:26     ` Stanislaw Gruszka
2012-03-19 17:03       ` Bart Van Assche
     [not found]         ` <4F6766F0.1070805-HInyCGIudOg@public.gmane.org>
2012-03-20 14:21           ` Stanislaw Gruszka
2012-03-20 14:31             ` Alan Stern
2012-03-19 17:04     ` Tejun Heo
2012-03-19 17:22       ` Bart Van Assche
2012-03-20 20:04       ` Bart Van Assche
2012-03-20 20:06       ` Bart Van Assche
2012-03-20 21:01         ` Dan Williams
2012-03-21  3:37           ` Dan Williams
2012-03-21 18:35             ` Dan Williams
2012-03-24 18:49             ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F65E09D.6010600@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).