From: Andy Grover <agrover@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
kiran.patil@intel.com
Subject: Re: [PATCH 07/13] target: Inline struct se_tmr_req into se_cmd
Date: Mon, 26 Mar 2012 09:08:44 -0700 [thread overview]
Message-ID: <4F70948C.9030505@redhat.com> (raw)
In-Reply-To: <20120326092559.GB27806@infradead.org>
On 03/26/2012 02:25 AM, Christoph Hellwig wrote:
> On Fri, Jan 20, 2012 at 09:44:43AM -0800, Andy Grover wrote:
>> On 01/20/2012 08:12 AM, Christoph Hellwig wrote:
>>> On Thu, Jan 19, 2012 at 01:39:17PM -0800, Andy Grover wrote:
>>>> This saves all fabrics from calling core_tmr_alloc_req() and
>>>> having to check the result. The downside is se_cmd gets bigger for all
>>>> requests, but hopefully later patches will reduce it.
>>>
>>> Without patches to void the overhead it's not acceptable. Fortunately
>>> it should be doable fairly simply by using an union for command vs
>>> TMR fields.
>>
>> This was my thought too. We should be able to move cmd variables into a
>> union w/tmr struct very soon, with a low risk of introducing bugs.
>
> Any plans on going back to this?
I'm working on a cleanup patch series that keeps getting bigger, and
this will either end up in it, or I'll get to it right afterwards.
-- Andy
next prev parent reply other threads:[~2012-03-26 16:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 21:39 [PATCH 0/13] Misc patches leading to target_submit_tmr Andy Grover
2012-01-19 21:39 ` [PATCH 01/13] scsi: Use struct scsi_lun in fc/fcp.h Andy Grover
2012-01-19 21:39 ` [PATCH 02/13] target: fix comment typos Andy Grover
2012-01-19 21:39 ` [PATCH 03/13] target: Remove unused struct se_queue_req Andy Grover
2012-01-19 21:39 ` [PATCH 04/13] target/iscsi: Remove unneeded wrapper functions Andy Grover
2012-01-19 21:39 ` [PATCH 05/13] target/fc: Simplify ft_send_work for tmr path Andy Grover
2012-01-19 21:39 ` [PATCH 06/13] target/fc: Remove cmd->cdb data member Andy Grover
2012-01-19 21:39 ` [PATCH 07/13] target: Inline struct se_tmr_req into se_cmd Andy Grover
2012-01-20 16:12 ` Christoph Hellwig
2012-01-20 17:44 ` Andy Grover
2012-02-16 0:05 ` Nicholas A. Bellinger
2012-02-16 6:30 ` Andy Grover
2012-02-16 8:08 ` Nicholas A. Bellinger
2012-03-26 9:25 ` Christoph Hellwig
2012-03-26 16:08 ` Andy Grover [this message]
2012-01-19 21:39 ` [PATCH 08/13] target/fc: Move core->fc code conversion earlier in ft_send_tm() Andy Grover
2012-01-19 21:39 ` [PATCH 09/13] target/fc: Call lookup_tmr_lun() for all TM types Andy Grover
2012-01-19 21:39 ` [PATCH 10/13] target/fc: Use transport_generic_free_cmd for ft_sess_put in ft_send_tm Andy Grover
2012-01-19 21:39 ` [PATCH 11/13] target: Add target_submit_tmr helper function Andy Grover
2012-01-19 21:39 ` [PATCH 12/13] target/fc: Use target_submit_tmr() Andy Grover
2012-01-19 21:39 ` [PATCH 13/13] target: Change target_submit_cmd() to return void Andy Grover
2012-01-20 0:46 ` Nicholas A. Bellinger
2012-01-21 3:27 ` Nicholas A. Bellinger
2012-01-19 23:57 ` [PATCH 0/13] Misc patches leading to target_submit_tmr Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F70948C.9030505@redhat.com \
--to=agrover@redhat.com \
--cc=hch@infradead.org \
--cc=kiran.patil@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).