From: Mike Christie <michaelc@cs.wisc.edu>
To: Roland Dreier <roland@kernel.org>
Cc: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro
Date: Tue, 27 Mar 2012 12:28:51 -0500 [thread overview]
Message-ID: <4F71F8D3.3080002@cs.wisc.edu> (raw)
In-Reply-To: <CAL1RGDX=hd=PX=VD_xjWWau01GcG8Ox_fj-FkMV5Exom_zQ++w@mail.gmail.com>
On 03/27/2012 11:38 AM, Roland Dreier wrote:
> On Wed, Feb 29, 2012 at 10:41 PM, Roland Dreier <roland@kernel.org> wrote:
>> From: Roland Dreier <roland@purestorage.com>
>>
>> Signed-off-by: Roland Dreier <roland@purestorage.com>
>> ---
>> drivers/scsi/be2iscsi/be.h | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/be2iscsi/be.h b/drivers/scsi/be2iscsi/be.h
>> index 1d7b976..a50b6a9 100644
>> --- a/drivers/scsi/be2iscsi/be.h
>> +++ b/drivers/scsi/be2iscsi/be.h
>> @@ -132,10 +132,6 @@ struct be_ctrl_info {
>> ((u32)((((size_t)(_address) & (PAGE_SIZE_4K - 1)) + \
>> (size) + (PAGE_SIZE_4K - 1)) >> PAGE_SHIFT_4K))
>>
>> -/* Byte offset into the page corresponding to given address */
>> -#define OFFSET_IN_PAGE(addr) \
>> - ((size_t)(addr) & (PAGE_SIZE_4K-1))
>> -
>> /* Returns bit offset within a DWORD of a bitfield */
>> #define AMAP_BIT_OFFSET(_struct, field) \
>> (((size_t)&(((_struct *)0)->field))%32)
>
> ping? the corresponding be2net patch is upstream as 97767a87f3be.
>
Jay probably missed it, because he has been sick. Looks good to me.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
next prev parent reply other threads:[~2012-03-27 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 6:41 [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro Roland Dreier
2012-03-27 16:38 ` Roland Dreier
2012-03-27 17:28 ` Mike Christie [this message]
2012-03-28 21:30 ` Jayamohan.Kallickal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71F8D3.3080002@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=JBottomley@parallels.com \
--cc=jayamohan.kallickal@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox