From: Tomas Henzl <thenzl@redhat.com>
To: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Cc: Achim_Leubner@pmc-sierra.com, Mahesh_Rajashekhara@pmc-sierra.com,
mark_salyzyn@xyratex.com
Subject: [PATCH] aacraid: add an iounmap call to aac_src_ioremap
Date: Thu, 29 Mar 2012 17:23:46 +0200 [thread overview]
Message-ID: <4F747E82.2020805@redhat.com> (raw)
The patch 116046127d1a3bad2853d02781ad9fee33f05e5a [SCSI] aacraid: Added Sync.mode to support series 7/8/9 controllers
removed an iounmap call from aac_src_ioremap. Before that, the iounmap has been called twice with the same value
(dev->base and dev->regs.src.bar0) and the iounmap complained about it (iounmap: bad address ...).
The proper solution is a change the paremeter from bar0 to bar1.
Fix this by adding a an iounmap(dev->regs.src.bar1) call.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 2bee515..7628206 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -424,6 +424,8 @@ static int aac_src_deliver_message(struct fib *fib)
static int aac_src_ioremap(struct aac_dev *dev, u32 size)
{
if (!size) {
+ iounmap(dev->regs.src.bar1);
+ dev->regs.src.bar1 = NULL;
iounmap(dev->regs.src.bar0);
dev->base = dev->regs.src.bar0 = NULL;
return 0;
next reply other threads:[~2012-03-29 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 15:23 Tomas Henzl [this message]
2012-04-13 9:03 ` [PATCH] aacraid: add an iounmap call to aac_src_ioremap Achim Leubner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F747E82.2020805@redhat.com \
--to=thenzl@redhat.com \
--cc=Achim_Leubner@pmc-sierra.com \
--cc=Mahesh_Rajashekhara@pmc-sierra.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@xyratex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).