[PATCH] aacraid: add an iounmap call to aac_src_ioremap

[PATCH] aacraid: add an iounmap call to aac_src_ioremap

[Tomas Henzl]

The patch 116046127d1a3bad2853d02781ad9fee33f05e5a [SCSI] aacraid: Added Sync.mode to support series 7/8/9 controllers
removed an iounmap call from  aac_src_ioremap. Before that, the iounmap has been called twice with the same value
(dev->base and dev->regs.src.bar0) and the iounmap complained about it (iounmap: bad address ...).

The proper solution is a change the paremeter from bar0 to bar1.
Fix this by adding a an iounmap(dev->regs.src.bar1) call.

Signed-off-by: Tomas Henzl <thenzl@redhat.com> 

diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 2bee515..7628206 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -424,6 +424,8 @@ static int aac_src_deliver_message(struct fib *fib)
 static int aac_src_ioremap(struct aac_dev *dev, u32 size)
 {
 	if (!size) {
+		iounmap(dev->regs.src.bar1);
+		dev->regs.src.bar1 = NULL;
 		iounmap(dev->regs.src.bar0);
 		dev->base = dev->regs.src.bar0 = NULL;
 		return 0;

RE: [PATCH] aacraid: add an iounmap call to aac_src_ioremap

[Achim Leubner]

Acked-by: Achim Leubner<achim_leubner@pmc-sierra.com>

Thanks,
Achim


-----Original Message-----
From: Tomas Henzl [mailto:thenzl@redhat.com] 
Sent: Donnerstag, 29. März 2012 17:24
To: 'linux-scsi@vger.kernel.org'
Cc: Achim Leubner; Mahesh Rajashekhara; mark_salyzyn@xyratex.com
Subject: [PATCH] aacraid: add an iounmap call to aac_src_ioremap

The patch 116046127d1a3bad2853d02781ad9fee33f05e5a [SCSI] aacraid: Added Sync.mode to support series 7/8/9 controllers
removed an iounmap call from  aac_src_ioremap. Before that, the iounmap has been called twice with the same value
(dev->base and dev->regs.src.bar0) and the iounmap complained about it (iounmap: bad address ...).

The proper solution is a change the paremeter from bar0 to bar1.
Fix this by adding a an iounmap(dev->regs.src.bar1) call.

Signed-off-by: Tomas Henzl <thenzl@redhat.com> 

diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 2bee515..7628206 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -424,6 +424,8 @@ static int aac_src_deliver_message(struct fib *fib)
 static int aac_src_ioremap(struct aac_dev *dev, u32 size)
 {
 	if (!size) {
+		iounmap(dev->regs.src.bar1);
+		dev->regs.src.bar1 = NULL;
 		iounmap(dev->regs.src.bar0);
 		dev->base = dev->regs.src.bar0 = NULL;
 		return 0;


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html