From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Miller Subject: Re: [PATCH] hpsa: use check_signature Date: Tue, 03 Apr 2012 10:45:46 -0500 Message-ID: <4F7B1B2A.7060602@hp.com> References: <1333431534-4595-1-git-send-email-akinobu.mita@gmail.com> <1333431534-4595-4-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1333431534-4595-4-git-send-email-akinobu.mita@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Akinobu Mita Cc: "linux-kernel@vger.kernel.org" , ISS StorageDev , "James E.J. Bottomley" , "linux-scsi@vger.kernel.org" List-Id: linux-scsi@vger.kernel.org On 04/03/2012 12:38 AM, Akinobu Mita wrote: > Use check_signature to find a signature in the mmio address. > > Signed-off-by: Akinobu Mita > Cc: Mike Miller > Cc: iss_storagedev@hp.com > Cc: "James E.J. Bottomley" > Cc: linux-scsi@vger.kernel.org Acked-by: Mike Miller > --- > drivers/scsi/hpsa.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index ddbf5fe..c867eeb 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -3839,10 +3839,7 @@ static void __devinit hpsa_find_board_params(struct ctlr_info *h) > > static inline bool hpsa_CISS_signature_present(struct ctlr_info *h) > { > - if ((readb(&h->cfgtable->Signature[0]) != 'C') || > - (readb(&h->cfgtable->Signature[1]) != 'I') || > - (readb(&h->cfgtable->Signature[2]) != 'S') || > - (readb(&h->cfgtable->Signature[3]) != 'S')) { > + if (!check_signature(h->cfgtable->Signature, "CISS", 4)) { > dev_warn(&h->pdev->dev, "not a valid CISS config table\n"); > return false; > }