Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: vikas.chaudhary@qlogic.com
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
	lalit.chandivade@qlogic.com, ravi.anand@qlogic.com,
	Tej Parkash <tej.parkash@qlogic.com>,
	Shyam Sundar <shyam.sundar@qlogic.com>
Subject: Re: [PATCH 5/6] qla4xxx: Capture minidump for ISP82XX on firmware failure
Date: Fri, 27 Apr 2012 11:05:15 -0500	[thread overview]
Message-ID: <4F9AC3BB.2050708@cs.wisc.edu> (raw)
In-Reply-To: <1335245557-17169-6-git-send-email-vikas.chaudhary@qlogic.com>

On 04/24/2012 12:32 AM, vikas.chaudhary@qlogic.com wrote:
> +
> +static ssize_t
> +qla4_8xxx_sysfs_write_fw_dump(struct file *filep, struct kobject *kobj,
> +			      struct bin_attribute *ba, char *buf, loff_t off,
> +			      size_t count)
> +{
> +	struct scsi_qla_host *ha = to_qla_host(dev_to_shost(container_of(kobj,
> +					       struct device, kobj)));
> +	uint32_t dev_state;
> +	int reading;
> +
> +	if (!is_qla8022(ha))
> +		return -EINVAL;
> +
> +	if (off != 0)
> +		return 0;
> +
> +	reading = simple_strtol(buf, NULL, 10);

I think we are supposed to be using kstrtol now.


  reply	other threads:[~2012-04-27 16:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24  5:32 [PATCH 0/6] qla4xxx: Update driver version to 5.02.00-k17 vikas.chaudhary
2012-04-24  5:32 ` [PATCH 1/6] qla4xxx: Correct early completion of pending mbox vikas.chaudhary
2012-04-24  5:32 ` [PATCH 2/6] qla4xxx: Fix kernel panic during discovery logout vikas.chaudhary
2012-04-24  5:32 ` [PATCH 3/6] qla4xxx: Fix clear ddb mbx command failure issue vikas.chaudhary
2012-04-24  5:32 ` [PATCH 4/6] qla4xxx: Add change_queue_depth API support vikas.chaudhary
2012-04-27 15:43   ` Mike Christie
2012-04-30 11:32     ` Vikas Chaudhary
2012-04-24  5:32 ` [PATCH 5/6] qla4xxx: Capture minidump for ISP82XX on firmware failure vikas.chaudhary
2012-04-27 16:05   ` Mike Christie [this message]
2012-05-17  9:12     ` James Bottomley
2012-05-18  9:29       ` Vikas Chaudhary
2012-04-24  5:32 ` [PATCH 6/6] qla4xxx: Update driver version to 5.02.00-k17 vikas.chaudhary
     [not found] <CBC865CB.E843%vikas.chaudhary@qlogic.com>
2012-05-04 10:00 ` [PATCH 5/6] qla4xxx: Capture minidump for ISP82XX on firmware failure Vikas Chaudhary
2012-05-04 10:17   ` Mike Christie
2012-05-04 10:29     ` Vikas Chaudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9AC3BB.2050708@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=jbottomley@parallels.com \
    --cc=lalit.chandivade@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ravi.anand@qlogic.com \
    --cc=shyam.sundar@qlogic.com \
    --cc=tej.parkash@qlogic.com \
    --cc=vikas.chaudhary@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox