From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Lord <kernel@teksavvy.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
James Bottomley <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Silence unnecessary warnings about ioctl to partition
Date: Fri, 04 May 2012 15:08:01 +0200 [thread overview]
Message-ID: <4FA3D4B1.9040308@redhat.com> (raw)
In-Reply-To: <4FA3D442.9050801@teksavvy.com>
Il 04/05/2012 15:06, Mark Lord ha scritto:
>> > I said which ioctls, not which options. I.e. cut-and-paste from dmesg.
> Here are some:
Thanks!
> messages.1:Apr 28 14:08:09 zbox5 kernel: [ 268.800536] hdparm: sending ioctl 330 to a partition!
> messages.1:Apr 28 14:08:09 zbox5 kernel: [ 268.800547] hdparm: sending ioctl 330 to a partition!
> messages.1:Apr 28 14:08:57 zbox5 kernel: [ 316.413944] hdparm: sending ioctl 330 to a partition!
> messages.1:Apr 28 14:08:57 zbox5 kernel: [ 316.413951] hdparm: sending ioctl 330 to a partition!
> messages.1:Apr 28 14:20:10 zbox5 kernel: [ 989.525085] hdparm: sending ioctl 330 to a partition!
> messages.1:Apr 28 14:20:10 zbox5 kernel: [ 989.525093] hdparm: sending ioctl 330 to a partition!
>
> The in <linux/hdreg.h> say this about 330:
>
> ...
> /* 0x330 is reserved - used to be HDIO_GETGEO_BIG */
> ...
>
> So it's HDIO_GETGEO_BIG, which doesn't exist in newer kernels.
> I wonder when that got removed? Minor userspace breakage there.
>
> hdparm issues it first as a backward-compatibility thing,
> before falling back to the even-more obsolete HDIO_GETGEO,
> which curiously enough is still in modern kernels.
Ok, so hdparm is not broken. My patch (which left the warning only for
SG_IO, and failed all other ioctls) would have worked, too.
Paolo
next prev parent reply other threads:[~2012-05-04 13:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 10:10 [PATCH] scsi: Silence unnecessary warnings about ioctl to partition Jan Kara
2012-05-02 10:15 ` Paolo Bonzini
2012-05-02 10:37 ` Jens Axboe
2012-05-02 10:54 ` Alan Cox
2012-05-02 11:02 ` Paolo Bonzini
2012-05-02 11:12 ` Alan Cox
2012-05-02 11:24 ` Paolo Bonzini
2012-05-02 12:05 ` Alan Cox
2012-05-02 12:23 ` Paolo Bonzini
2012-05-02 19:38 ` Mark Lord
2012-05-03 7:47 ` Paolo Bonzini
2012-05-03 12:40 ` Mark Lord
2012-05-03 12:47 ` Paolo Bonzini
2012-05-03 17:36 ` Mark Lord
2012-05-04 6:39 ` Paolo Bonzini
2012-05-04 13:06 ` Mark Lord
2012-05-04 13:08 ` Paolo Bonzini [this message]
2012-05-04 13:11 ` Mark Lord
2012-05-04 13:24 ` Mark Lord
2012-05-02 13:51 ` Jan Kara
2012-05-02 13:59 ` Paolo Bonzini
2012-05-02 15:10 ` Alan Cox
2012-05-02 15:49 ` Paolo Bonzini
2012-05-02 20:49 ` Paolo Bonzini
2012-05-02 19:49 ` Jan Kara
2012-05-02 21:16 ` Paolo Bonzini
2012-06-15 8:14 ` Paolo Bonzini
2012-06-15 8:46 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2012-06-15 10:50 Jan Kara
2012-06-15 10:51 ` Jens Axboe
2012-06-15 13:58 ` Nick Bowler
2012-06-15 14:22 ` Paolo Bonzini
2012-06-15 14:23 ` Jan Kara
2012-06-15 14:31 ` Nick Bowler
2012-06-15 11:00 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA3D4B1.9040308@redhat.com \
--to=pbonzini@redhat.com \
--cc=JBottomley@parallels.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=kernel@teksavvy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).