linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, jejb@linux.vnet.ibm.com,
	hare@suse.de, Damien.LeMoal@wdc.com
Subject: Re: [PATCH v4 00/14] scsi_debug: host managed ZBC + doublestore
Date: Mon, 13 Apr 2020 22:49:39 -0400	[thread overview]
Message-ID: <4bbcf1f6-1dc1-ccaf-c39a-0e2a98f0fbdf@interlog.com> (raw)
In-Reply-To: <yq1mu7fug6k.fsf@oracle.com>

On 2020-04-13 7:19 p.m., Martin K. Petersen wrote:

in response to the cover letter of a patchset sent: 2020-02-25, 1:23 a.m.
which is 7 weeks ago!

> Evening Doug!
> 
>> The major addition is support for host-managed ZBC devices.  The bulk
>> of the work in this area was done by Damien Le Moal.  It allows ZBC
>> devices with a mix of conventional and "sequential write required"
>> zones to be specified.
> 
> [...]
> 
>> The lower numbered patches in this set contain various measures to
>> improve the speed and usefulness of this driver.  It is being used to
>> test the rewrite of the SCSI generic (sg) driver which is still
>> underway.
> 
> These really should be separate series. One for the ZBC stuff (which
> generally looks OK), one for the backing store enablement, and maybe one
> for the general improvements that do not have other dependencies.

But other things such as the "ZBC stuff" have dependencies on those
general improvements in obvious (i.e. seen by git) and subtle ways.

> It's much more manageable for reviewers when things come in smaller
> batches. Once a posted series has been merged, you can rebase your
> working tree and submit the next batch of 5-10 patches.

I believe you overvalue the review process, it is mainly window
dressing, unevenly applied.

Doug Gilbert



      reply	other threads:[~2020-04-14  2:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25  6:23 [PATCH v4 00/14] scsi_debug: host managed ZBC + doublestore Douglas Gilbert
2020-02-25  6:23 ` [PATCH v4 01/14] scsi_debug: randomize command completion time Douglas Gilbert
2020-04-13 22:24   ` Martin K. Petersen
2020-02-25  6:23 ` [PATCH v4 02/14] scsi_debug: add doublestore option Douglas Gilbert
2020-04-13 22:36   ` Martin K. Petersen
2020-02-25  6:23 ` [PATCH v4 03/14] scsi_debug: implement verify(10), add verify(16) Douglas Gilbert
2020-04-13 22:48   ` Martin K. Petersen
2020-02-25  6:23 ` [PATCH v4 04/14] scsi_debug: weaken rwlock around ramdisk access Douglas Gilbert
2020-02-25  6:23 ` [PATCH v4 05/14] scsi_debug: improve command duration calculation Douglas Gilbert
2020-04-13 22:50   ` Martin K. Petersen
2020-02-25  6:23 ` [PATCH v4 06/14] scsi_debug: implement pre-fetch commands Douglas Gilbert
2020-04-13 22:57   ` Martin K. Petersen
2020-04-19 18:01     ` Douglas Gilbert
2020-04-19 18:22       ` Julian Wiedmann
2020-04-19 21:53         ` Douglas Gilbert
2020-02-25  6:23 ` [PATCH v4 07/14] scsi_debug: expand zbc support Douglas Gilbert
2020-04-13 23:00   ` Martin K. Petersen
2020-04-13 23:05     ` Damien Le Moal
2020-04-13 23:06       ` Damien Le Moal
2020-04-14  1:55         ` Martin K. Petersen
2020-04-14  5:38           ` Damien Le Moal
2020-02-25  6:23 ` [PATCH v4 08/14] scsi_debug: add zone commands Douglas Gilbert
2020-02-25  6:23 ` [PATCH v4 09/14] scsi_debug: add zbc parameter Douglas Gilbert
2020-04-15  2:10   ` Martin K. Petersen
2020-02-25  6:23 ` [PATCH v4 10/14] scsi_debug: re-arrange parameters alphabetically Douglas Gilbert
2020-02-25  6:23 ` [PATCH v4 11/14] scsi_debug: zone_max_open module parameter Douglas Gilbert
2020-02-25  6:23 ` [PATCH v4 12/14] scsi_debug: zone_nr_conv " Douglas Gilbert
2020-02-25  6:23 ` [PATCH v4 13/14] scsi_debug: zone_size_mb " Douglas Gilbert
2020-02-25  6:23 ` [PATCH v4 14/14] scsi_debug: bump to version 1.89 Douglas Gilbert
2020-04-13 23:19 ` [PATCH v4 00/14] scsi_debug: host managed ZBC + doublestore Martin K. Petersen
2020-04-14  2:49   ` Douglas Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bbcf1f6-1dc1-ccaf-c39a-0e2a98f0fbdf@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).