From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Chandrakanth patil <chandrakanth.patil@broadcom.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2][next] scsi: megaraid_sas: Avoid a couple -Wflex-array-member-not-at-end warnings
Date: Tue, 07 Oct 2025 07:59:32 -0400 [thread overview]
Message-ID: <4cf727c56c4fda8d28df920214b3824c9739bc8f.camel@HansenPartnership.com> (raw)
In-Reply-To: <3a80fd1d-5a05-4db3-9dda-3ad38bedfb38@embeddedor.com>
On Tue, 2025-10-07 at 11:43 +0100, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
After what happened with the qla2xxx driver, everyone is a bit wary of
these changes, particularly when they affect structures shared with the
hardware. Megaraid is a broadcom acquisition so although maintained it
might take them a while to check this.
However, you could help us with this: as I understand it (there is a
bit of a no documentation problem here), the TRAILING_OVERLAP formalism
merely gets the compiler not to warn about the situation rather than
actually changing anything in the layout of the structure? In which
case you should be able to demonstrate the binary produced before and
after this patch is the same, which would very much reduce the risk of
taking it.
Regards,
James
next prev parent reply other threads:[~2025-10-07 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 11:56 [PATCH v2][next] scsi: megaraid_sas: Avoid a couple -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-10-07 10:43 ` Gustavo A. R. Silva
2025-10-07 11:59 ` James Bottomley [this message]
2025-10-07 14:18 ` Gustavo A. R. Silva
2025-10-07 22:56 ` James Bottomley
2025-10-08 9:28 ` Gustavo A. R. Silva
2025-10-14 21:55 ` Martin K. Petersen
2025-10-14 21:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cf727c56c4fda8d28df920214b3824c9739bc8f.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=kashyap.desai@broadcom.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox