From: Bean Huo <huobean@gmail.com>
To: Asutosh Das <quic_asutoshd@quicinc.com>,
quic_cang@quicinc.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: quic_nguyenb@quicinc.com, quic_xiaosenh@quicinc.com,
stanley.chu@mediatek.com, eddie.huang@mediatek.com,
daejun7.park@samsung.com, bvanassche@acm.org,
avri.altman@wdc.com, mani@kernel.org, beanhuo@micron.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v11 00/16] Add Multi Circular Queue Support
Date: Thu, 15 Dec 2022 17:44:58 +0100 [thread overview]
Message-ID: <4d8e2b27-2804-e8ad-1e35-0942538b5617@gmail.com> (raw)
In-Reply-To: <cover.1670541363.git.quic_asutoshd@quicinc.com>
Asutosh,
I reviewed the entire patch series and applied them to Martin's
6.2/staging branch,
No logic issues were found, other than these minor compilation warnings:
drivers/ufs/core/ufs-mcq.c:87: warning: Function parameter or member
'hba' not described in 'ufshcd_mcq_config_mac'
drivers/ufs/core/ufs-mcq.c:87: warning: Function parameter or member
'max_active_cmds' not described in 'ufshcd_mcq_config_mac'
drivers/ufs/core/ufs-mcq.c:107: warning: Function parameter or member
'hba' not described in 'ufshcd_mcq_req_to_hwq'
drivers/ufs/core/ufs-mcq.c:107: warning: Function parameter or member
'req' not described in 'ufshcd_mcq_req_to_hwq'
drivers/ufs/core/ufs-mcq.c:128: warning: Function parameter or member
'hba' not described in 'ufshcd_mcq_decide_queue_depth'
so:
Reviewed-by: Bean Huo <beanhuo@micron.com>
Kind regards,
Bean
next prev parent reply other threads:[~2022-12-15 16:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 23:18 [PATCH v11 00/16] Add Multi Circular Queue Support Asutosh Das
2022-12-08 23:18 ` [PATCH v11 01/16] ufs: core: Optimize duplicate code to read extended feature Asutosh Das
2022-12-08 23:18 ` [PATCH v11 02/16] ufs: core: Probe for ext_iid support Asutosh Das
2022-12-08 23:18 ` [PATCH v11 03/16] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-12-08 23:18 ` [PATCH v11 04/16] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-12-08 23:18 ` [PATCH v11 05/16] ufs: core: mcq: Add support to allocate multiple queues Asutosh Das
2022-12-08 23:18 ` [PATCH v11 06/16] ufs: core: mcq: Configure resource regions Asutosh Das
2022-12-13 1:10 ` Stanley Chu
2022-12-08 23:18 ` [PATCH v11 07/16] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-12-13 1:12 ` Stanley Chu
2022-12-08 23:18 ` [PATCH v11 08/16] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-12-08 23:18 ` [PATCH v11 09/16] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-12-08 23:18 ` [PATCH v11 10/16] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-12-13 1:15 ` Stanley Chu
2022-12-08 23:18 ` [PATCH v11 11/16] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-12-13 1:37 ` Stanley Chu
2022-12-08 23:18 ` [PATCH v11 12/16] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-12-08 23:18 ` [PATCH v11 13/16] ufs: core: Prepare for completion in mcq Asutosh Das
2022-12-13 1:35 ` Stanley Chu
2022-12-08 23:18 ` [PATCH v11 14/16] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-12-13 1:35 ` Stanley Chu
2022-12-08 23:18 ` [PATCH v11 15/16] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-12-13 1:36 ` Stanley Chu
2022-12-08 23:18 ` [PATCH v11 16/16] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das
2022-12-13 1:37 ` Stanley Chu
2022-12-15 16:44 ` Bean Huo [this message]
2022-12-30 22:25 ` [PATCH v11 00/16] Add Multi Circular Queue Support Martin K. Petersen
2023-01-05 16:54 ` Asutosh Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8e2b27-2804-e8ad-1e35-0942538b5617@gmail.com \
--to=huobean@gmail.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=eddie.huang@mediatek.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox