Re: [PATCH 07/15] rbd: use bvec_virt

Jeff Layton
2021-08-05T12:01:18Z

On Wed, 2021-08-04 at 11:56 +0200, Christoph Hellwig wrote:
> Use bvec_virt instead of open coding it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/block/rbd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 6d596c2c2cd6..e65c9d706f6f 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -2986,8 +2986,7 @@ static bool is_zero_bvecs(struct bio_vec *bvecs, u32 bytes)
> };
>
> ceph_bvec_iter_advance_step(&it, bytes, ({
> - if (memchr_inv(page_address(bv.bv_page) + bv.bv_offset, 0,
> - bv.bv_len))
> + if (memchr_inv(bvec_virt(&bv), 0, bv.bv_len))
> return false;
> }));
> return true;

LGTM

Reviewed-by: Jeff Layton <jlayton@kernel.org>