From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RESEND 0/5] Add vhost-blk support Date: Tue, 17 Jul 2012 18:09:28 +0300 Message-ID: <20120717150928.GB11587@redhat.com> References: <1342169711-12386-1-git-send-email-asias@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1342169711-12386-1-git-send-email-asias@redhat.com> Sender: owner-linux-aio@kvack.org To: Asias He Cc: linux-kernel@vger.kernel.org, Alexander Viro , Benjamin LaHaise , James Bottomley , Jeff Moyer , kvm@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, target-devel , linux-scsi , lf-virt , Stefan Hajnoczi , Zhi Yong Wu , Anthony Liguori , Paolo Bonzini , Christoph Hellwig , Jens Axboe , Hannes Reinecke List-Id: linux-scsi@vger.kernel.org On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: > > Hi folks, > > [I am resending to fix the broken thread in the previous one.] > > This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk > device accelerator. Compared to userspace virtio-blk implementation, vhost-blk > gives about 5% to 15% performance improvement. Same thing as tcm_host comment: It seems not 100% clear whether this driver will have major userspace using it. And if not, it would be very hard to support a driver when recent userspace does not use it in the end. I think a good idea for 3.6 would be to make it depend on CONFIG_STAGING. Then we don't commit to an ABI. For this, you can add a separate Kconfig and source it from drivers/staging/Kconfig. Maybe it needs to be in a separate directory drivers/vhost/staging/Kconfig. I Cc'd the list of tcm_host in the hope that you can cooperate on this. -- MST -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Asias He Subject: Re: [PATCH RESEND 0/5] Add vhost-blk support Date: Wed, 18 Jul 2012 10:09:23 +0800 Message-ID: <50061AD3.6030704@redhat.com> References: <1342169711-12386-1-git-send-email-asias@redhat.com> <20120717150928.GB11587@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120717150928.GB11587@redhat.com> Sender: owner-linux-aio@kvack.org To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Alexander Viro , Benjamin LaHaise , James Bottomley , Jeff Moyer , kvm@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, target-devel , linux-scsi , lf-virt , Stefan Hajnoczi , Zhi Yong Wu , Anthony Liguori , Paolo Bonzini , Christoph Hellwig , Jens Axboe , Hannes Reinecke List-Id: linux-scsi@vger.kernel.org On 07/17/2012 11:09 PM, Michael S. Tsirkin wrote: > On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: >> >> Hi folks, >> >> [I am resending to fix the broken thread in the previous one.] >> >> This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk >> device accelerator. Compared to userspace virtio-blk implementation, vhost-blk >> gives about 5% to 15% performance improvement. > > Same thing as tcm_host comment: > > It seems not 100% clear whether this driver will have major > userspace using it. And if not, it would be very hard to support a > driver when recent userspace does not use it in the end. > > I think a good idea for 3.6 would be to make it depend on > CONFIG_STAGING. Then we don't commit to an ABI. For this, you can add > a separate Kconfig and source it from drivers/staging/Kconfig. Maybe it > needs to be in a separate directory drivers/vhost/staging/Kconfig. OK. > I Cc'd the list of tcm_host in the hope that you can cooperate on this. Sure. -- Asias -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: Re: [PATCH RESEND 0/5] Add vhost-blk support Date: Wed, 18 Jul 2012 12:42:09 +0100 Message-ID: References: <1342169711-12386-1-git-send-email-asias@redhat.com> <20120717150928.GB11587@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20120717150928.GB11587@redhat.com> Sender: kvm-owner@vger.kernel.org To: "Michael S. Tsirkin" Cc: Asias He , Jens Axboe , linux-aio@kvack.org, target-devel , linux-scsi , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, lf-virt , James Bottomley , Anthony Liguori , Jeff Moyer , Benjamin LaHaise , Alexander Viro , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Zhi Yong Wu , Christoph Hellwig , Stefan Hajnoczi List-Id: linux-scsi@vger.kernel.org On Tue, Jul 17, 2012 at 4:09 PM, Michael S. Tsirkin wrote: > On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: >> >> Hi folks, >> >> [I am resending to fix the broken thread in the previous one.] >> >> This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk >> device accelerator. Compared to userspace virtio-blk implementation, vhost-blk >> gives about 5% to 15% performance improvement. > > Same thing as tcm_host comment: > > It seems not 100% clear whether this driver will have major > userspace using it. And if not, it would be very hard to support a > driver when recent userspace does not use it in the end. > > I think a good idea for 3.6 would be to make it depend on > CONFIG_STAGING. Then we don't commit to an ABI. For this, you can add > a separate Kconfig and source it from drivers/staging/Kconfig. Maybe it > needs to be in a separate directory drivers/vhost/staging/Kconfig. > > I Cc'd the list of tcm_host in the hope that you can cooperate on this. > Adding it to staging allows more people to try it out, so that's a good thing. If I get a moment to play with it I'll let you know the results. Stefan