* [patch 1/2] [SCSI] ipr: missing unlock before a return
@ 2012-07-30 8:16 Dan Carpenter
2012-07-30 12:33 ` Brian King
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-07-30 8:16 UTC (permalink / raw)
To: Brian King
Cc: James E.J. Bottomley, linux-scsi, linux-kernel, kernel-janitors
We recently changed the locking in this function, but this return was
missed. It needs an unlock and the IRQs need to be restored.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Applies to linux-next.
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 07b14ba..7a5ccb2c 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -5874,8 +5874,11 @@ static int ipr_queuecommand(struct Scsi_Host *shost,
goto err_nodev;
}
- if (ipr_is_gata(res) && res->sata_port)
- return ata_sas_queuecmd(scsi_cmd, res->sata_port->ap);
+ if (ipr_is_gata(res) && res->sata_port) {
+ rc = ata_sas_queuecmd(scsi_cmd, res->sata_port->ap);
+ spin_unlock_irqrestore(shost->host_lock, lock_flags);
+ return rc;
+ }
ipr_cmd = __ipr_get_free_ipr_cmnd(ioa_cfg);
spin_unlock_irqrestore(shost->host_lock, lock_flags);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 1/2] [SCSI] ipr: missing unlock before a return
2012-07-30 8:16 [patch 1/2] [SCSI] ipr: missing unlock before a return Dan Carpenter
@ 2012-07-30 12:33 ` Brian King
0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2012-07-30 12:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Brian King, James E.J. Bottomley, linux-scsi, linux-kernel,
kernel-janitors
On 07/30/2012 03:16 AM, Dan Carpenter wrote:
> We recently changed the locking in this function, but this return was
> missed. It needs an unlock and the IRQs need to be restored.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks for catching this.
Acked-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-30 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-30 8:16 [patch 1/2] [SCSI] ipr: missing unlock before a return Dan Carpenter
2012-07-30 12:33 ` Brian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).