From: Bart Van Assche <bvanassche@acm.org>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Chanho Min <chanho0207@gmail.com>,
James Bottomley <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue
Date: Sat, 04 Aug 2012 20:18:41 +0000 [thread overview]
Message-ID: <501D83A1.7040900@acm.org> (raw)
In-Reply-To: <501D51D1.2010806@cs.wisc.edu>
On 08/04/12 16:46, Mike Christie wrote:
> I think we have to have scsi-ml do a get_device when a sdev is added to
> the starved entry and then do a put_device when it is removed (must do
> these under the host lock for the starved entry case too). I am not sure
> if that is just a hack/papering-over of the problem and there are more
> issues like this.
That would result in a more complex patch than the patch at the start of
this thread, isn't it ? Also, IMHO it would help to document which
functions in the scsi-ml are called with an sdev reference and which
ones not. That would make the scsi-ml code easier to verify for issues
like the one reported at the start of this thread.
Bart.
next prev parent reply other threads:[~2012-08-04 20:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 8:41 [PATCH] fix NULL-pointer dereference on scsi_run_queue Chanho Min
2012-08-02 8:57 ` James Bottomley
2012-08-02 9:28 ` Chanho Min
2012-08-02 9:34 ` James Bottomley
2012-08-03 2:28 ` Chanho Min
2012-08-03 3:01 ` Mike Christie
2012-08-04 9:01 ` Bart Van Assche
2012-08-04 16:46 ` Mike Christie
2012-08-04 20:18 ` Bart Van Assche [this message]
2012-08-04 22:36 ` Mike Christie
2012-08-06 17:56 ` Bart Van Assche
2012-08-07 8:53 ` Chanho Min
2012-08-07 9:30 ` Bart Van Assche
2012-08-08 3:42 ` Chanho Min
2012-08-08 7:37 ` Bart Van Assche
2012-08-07 9:43 ` Bart Van Assche
2012-08-07 16:16 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501D83A1.7040900@acm.org \
--to=bvanassche@acm.org \
--cc=JBottomley@parallels.com \
--cc=axboe@kernel.dk \
--cc=chanho0207@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).