Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Rob Evers <revers@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Kai.Makisara@kolumbus.fi, jeffm@suse.com, lduncan@suse.com,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC] increase ST_MAX_TAPES from 128 to 1024
Date: Fri, 17 Aug 2012 16:57:49 -0400	[thread overview]
Message-ID: <502EB04D.2000007@redhat.com> (raw)
In-Reply-To: <1345217873.2838.12.camel@dabdike.int.hansenpartnership.com>

On 08/17/2012 11:37 AM, James Bottomley wrote:
> On Fri, 2012-08-17 at 10:50 -0400, Rob Evers wrote:
>> Wondering if this would be an acceptable interim solution
>> to increasing the limit on the number of tape drives
>> while http://marc.info/?l=linux-scsi&m=134212042809524&w=2
>> gets sorted out.
>>
>> Signed-off-by: Rob Evers<revers@redhat.com>
>> ---
>>   drivers/scsi/st.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/st.h b/drivers/scsi/st.h
>> index b548923..408d24f 100644
>> --- a/drivers/scsi/st.h
>> +++ b/drivers/scsi/st.h
>> @@ -76,7 +76,7 @@ struct st_modedef {
>>   #define ST_MODE_SHIFT (7 - ST_NBR_MODE_BITS)
>>   #define ST_MODE_MASK ((ST_NBR_MODES - 1)<<  ST_MODE_SHIFT)
>>
>> -#define ST_MAX_TAPES 128
>> +#define ST_MAX_TAPES 1024
> This is going to cause an order 2 GFP_ATOMIC allocation (on 64 bit
> platforms) for the contiguous scsi_tapes array ... if large numbers of
> tapes are genuinely required, shouldn't we fix this first and then
> expand the number quite a bit more?
>
> James
>

Pre allocation of cdevs during init time needs addressing as well
to increase ST_MAX_TAPES quite a bit more, right?

Would leaving out Lee's sysfs updates out be ok, if ST_MAX_TAPES were
significantly increased?

Rob


  reply	other threads:[~2012-08-17 20:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 14:50 [PATCH RFC] increase ST_MAX_TAPES from 128 to 1024 Rob Evers
2012-08-17 15:19 ` Jeff Mahoney
2012-08-17 15:37 ` James Bottomley
2012-08-17 20:57   ` Rob Evers [this message]
2012-08-17 21:35     ` Jeff Mahoney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502EB04D.2000007@redhat.com \
    --to=revers@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=jeffm@suse.com \
    --cc=lduncan@suse.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox