From: Bart Van Assche <bvanassche@acm.org>
To: Dan Williams <djbw@fb.com>
Cc: JBottomley@parallels.com, John Drescher <drescherjm@gmail.com>,
stable@vger.kernel.org, linux-scsi@vger.kernel.org,
Jack Wang <jack_wang@usish.com>
Subject: Re: [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove
Date: Wed, 29 Aug 2012 06:50:08 +0000 [thread overview]
Message-ID: <503DBBA0.5060108@acm.org> (raw)
In-Reply-To: <20120829051119.26395.15980.stgit@localhost.localdomain>
On 08/29/12 05:12, Dan Williams wrote:
> John reports:
> BUG: soft lockup - CPU#2 stuck for 23s! [kworker/u:8:2202]
> [..]
> Call Trace:
> [<ffffffff8141782a>] scsi_remove_target+0xda/0x1f0
> [<ffffffff81421de5>] sas_rphy_remove+0x55/0x60
> [<ffffffff81421e01>] sas_rphy_delete+0x11/0x20
> [<ffffffff81421e35>] sas_port_delete+0x25/0x160
> [<ffffffff814549a3>] mptsas_del_end_device+0x183/0x270
>
> ...introduced by commit 3b661a9 "[SCSI] fix hot unplug vs async scan race".
Including that call stack in the patch description may create the
misleading impression that this only occurs with the mptsas driver. This
lockup also happens with at least the iSCSI initiator. See also
http://lkml.org/lkml/2012/8/24/340.
By the way, in order to get a patch in the stable tree the proper "Cc:"
tag should be added in the patch description but the
stable@vger.kernel.org e-mail address should be left out from the
Cc-list of the e-mail with the patch.
Bart.
next prev parent reply other threads:[~2012-08-29 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 5:12 [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove Dan Williams
2012-08-29 6:50 ` Bart Van Assche [this message]
2012-08-29 14:59 ` Dan Williams
2012-09-04 14:02 ` John Drescher
2012-09-04 23:01 ` Dan Williams
2012-09-01 16:01 ` Stefan Ring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503DBBA0.5060108@acm.org \
--to=bvanassche@acm.org \
--cc=JBottomley@parallels.com \
--cc=djbw@fb.com \
--cc=drescherjm@gmail.com \
--cc=jack_wang@usish.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).