linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Bart Van Assche <bvanassche@acm.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Mike Snitzer <snitzer@redhat.com>,
	Babu Moger <babu.moger@netapp.com>
Subject: Re: [PATCH] scsi_dh_alua: Enable STPG for unavailable ports
Date: Thu, 20 Sep 2012 07:28:29 +0200	[thread overview]
Message-ID: <505AA97D.7040005@suse.de> (raw)
In-Reply-To: <5059E97E.1000500@cs.wisc.edu>

On 09/19/2012 05:49 PM, Mike Christie wrote:
> On 08/24/2012 04:08 AM, Bart Van Assche wrote:
>> A quote from SPC-4: "While in the unavailable primary target port
>> asymmetric access state, the device server shall support those of
>> the following commands that it supports while in the active/optimized
>> state: [ ... ] d) SET TARGET PORT GROUPS; [ ... ]". Hence enable
>> sending STPG to a target port group that is in the unavailable state.
>>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> Cc: Hannes Reinecke <hare@suse.de>
>> Cc: Mike Christie <michaelc@cs.wisc.edu>
>> Cc: Mike Snitzer <snitzer@redhat.com>
>> Cc: Babu Moger <babu.moger@netapp.com>
>> Cc: <stable@vger.kernel.org>
>> ---
>>  drivers/scsi/device_handler/scsi_dh_alua.c |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
>> index 08d80a6..a05d469 100644
>> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
>> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
>> @@ -641,8 +641,7 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_dh_data *h)
>>  		h->state = TPGS_STATE_STANDBY;
>>  		break;
>>  	case TPGS_STATE_OFFLINE:
>> -	case TPGS_STATE_UNAVAILABLE:
>> -		/* Path unusable for unavailable/offline */
>> +		/* Path unusable */
>>  		err = SCSI_DH_DEV_OFFLINED;
>>  		break;
>>  	default:
>>
> 
> Hey, was this patch ok Hannes and James and others?
> 
> I see bb2c94a3a6ad37fe7d34f369295bcdf5387e264f was merged, but this one
> was not.
> 
> I was thinking this might have got missed because it has the same patch
> description as  bb2c94a3a6ad37fe7d34f369295bcdf5387e264f, so it is
> confusion, but they are different patches. One fixes alua_rtpg and one
> fixes alua_activate, but both are needed.
> 
Yeah, patch's okay.

Acked-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-09-20  5:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24  9:08 [PATCH] scsi_dh_alua: Enable STPG for unavailable ports Bart Van Assche
2012-08-24 16:37 ` Michael Christie
2012-09-19 15:49 ` Mike Christie
2012-09-20  5:28   ` Hannes Reinecke [this message]
2012-09-19 17:36 ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505AA97D.7040005@suse.de \
    --to=hare@suse.de \
    --cc=babu.moger@netapp.com \
    --cc=bvanassche@acm.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).