From: Hannes Reinecke <hare@suse.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: James Bottomley <jbottomley@parallels.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 00/10] scsi: avoid linebreaks in syslog output
Date: Mon, 15 Oct 2012 08:02:17 +0200 [thread overview]
Message-ID: <507BA6E9.8020002@suse.de> (raw)
In-Reply-To: <CAMM=eLfLq3sqm4hkiCAqB2m75+1UN+3O0pvYMOES-xHT9PHiwA@mail.gmail.com>
On 10/15/2012 02:19 AM, Mike Snitzer wrote:
> On Fri, Oct 12, 2012 at 4:33 AM, Hannes Reinecke <hare@suse.de> wrote:
>> This patchset updates the SCSI midlayer to use dev_printk() instead
>> of the simple printk(). The main objective here is to avoid line-breaks
>> in syslog output; with the current state it's nearly impossible to match
>> the output to the occurring device; under high load even the CDB will
>> be split off into individual bytes, spread randomly across the lines.
>> Which makes debugging via scsi_logging_level _really_ hard.
>> In addition we'll be getting the syslog messages nicely prefixed with
>> the device, which will make userspace logging daemons happy.
>>
>> Before:
>> [ 297.300605] sd 2:0:3:2: Send:
>> [ 297.300607] 0xffff8802348b0980
>> [ 297.300610] sd 2:0:3:2: CDB:
>> [ 297.300615] Test Unit Ready: 00 00 00 00 00 00
>> [ 297.300747] sd 2:0:3:2: Done:
>> [ 297.300750] 0xffff8802348b0980 SUCCESS
>> [ 297.300753] sd 2:0:3:2:
>> [ 297.300755] Result: hostbyte=DID_OK driverbyte=DRIVER_OK
>> [ 297.300758] sd 2:0:3:2: CDB:
>> [ 297.300764] Test Unit Ready: 00 00 00 00 00 00
>> [ 297.300766] sd 2:0:3:2:
>> [ 297.300769] Sense Key : Unit Attention [current]
>> [ 297.300771] Info fld=0x0
>> [ 297.300772] sd 2:0:3:2:
>> [ 297.300776] Add. Sense: Capacity data has changed
>>
>> After:
>> [ 636.683556] sd 2:0:3:2: Send: 0xffff88043145eec0
>> [ 636.727856] sd 2:0:3:2: CDB: Test Unit Ready: 00 00 00 00 00 00
>> [ 636.785330] sd 2:0:3:2: Done: 0xffff88043145eec0 SUCCESS
>> [ 636.838228] sd 2:0:3:2: Result: hostbyte=DID_OK driverbyte=DRIVER_OK
>> [ 636.899099] sd 2:0:3:2: CDB: Test Unit Ready: 00 00 00 00 00 00
>> [ 636.955905] sd 2:0:3:2: Sense Key : Unit Attention [current]
>> [ 637.069179] sd 2:0:3:2: Add. Sense: Capacity data has changed
>
> I know there are a lot of changes here but shouldn't all this get
> fixed in stable 3.5+?
>
If you ask me, yes, of course.
I can easily post a v2 of the patchset (meanwhile I've got another
patch for st :-), Cc'ing stable with it.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-15 6:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 8:33 [PATCH 00/10] scsi: avoid linebreaks in syslog output Hannes Reinecke
2012-10-12 8:33 ` [PATCH 01/10] sg: Use dev_printk Hannes Reinecke
2012-10-12 14:34 ` Douglas Gilbert
2012-10-12 8:33 ` [PATCH 02/10] sr: Use dev_printk() Hannes Reinecke
2012-10-12 8:33 ` [PATCH 03/10] scsi: Avoid linebreaks in syslog output Hannes Reinecke
2012-10-12 8:33 ` [PATCH 04/10] scsi: Use sdev_printk() for logging Hannes Reinecke
2012-10-12 8:33 ` [PATCH 05/10] scsi: use buffer for print_opcode_name() Hannes Reinecke
2012-10-12 8:33 ` [PATCH 06/10] scsi: use single printk call in scsi_print_command() Hannes Reinecke
2012-10-12 8:33 ` [PATCH 07/10] scsi: use buffer for scsi_show_result() Hannes Reinecke
2012-10-12 8:33 ` [PATCH 08/10] scsi: open-code scsi_decode_sense_buffer() Hannes Reinecke
2012-10-12 8:33 ` [PATCH 09/10] scsi: decode descriptor sense Hannes Reinecke
2012-10-12 8:33 ` [PATCH 10/10] scsi: use local buffer for decoding sense data Hannes Reinecke
2012-10-15 0:19 ` [PATCH 00/10] scsi: avoid linebreaks in syslog output Mike Snitzer
2012-10-15 6:02 ` Hannes Reinecke [this message]
2013-12-20 13:25 ` Tomas Henzl
2013-12-20 13:31 ` Hannes Reinecke
2013-12-20 13:35 ` Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507BA6E9.8020002@suse.de \
--to=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).