* [PATCH v2 05/19] be2iscsi: Display driver name and version in device attribute
@ 2012-10-19 23:12 John Soni Jose
2012-10-24 7:00 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: John Soni Jose @ 2012-10-19 23:12 UTC (permalink / raw)
To: michaelc, linux-scsi; +Cc: John Soni Jose, Jayamohan Kallickal
Signed-off-by: John Soni Jose <sony.john-n@emulex.com>
Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
---
drivers/scsi/be2iscsi/be_main.c | 2 ++
drivers/scsi/be2iscsi/be_mgmt.c | 16 ++++++++++++++++
drivers/scsi/be2iscsi/be_mgmt.h | 3 +++
3 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 2d1bbb8..bd0f49f 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -153,8 +153,10 @@ BEISCSI_RW_ATTR(log_enable, 0x00,
"\t\t\t\tIO Path Events : 0x10\n"
"\t\t\t\tConfiguration Path : 0x20\n");
+DEVICE_ATTR(beiscsi_drvr_ver, S_IRUGO, beiscsi_drvr_ver_disp, NULL);
struct device_attribute *beiscsi_attrs[] = {
&dev_attr_beiscsi_log_enable,
+ &dev_attr_beiscsi_drvr_ver,
NULL,
};
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index aab5dd3..1ec1db3 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -1136,3 +1136,19 @@ int mgmt_set_vlan(struct beiscsi_hba *phba,
free_mcc_tag(&phba->ctrl, tag);
return 0;
}
+
+/**
+ * beiscsi_drvr_ver_disp()- Display the driver Name and Version
+ * @dev: ptr to device not used.
+ * @attr: device attribute, not used.
+ * @buf: contains formatted text driver name and version
+ *
+ * return
+ * size of the formatted string
+ **/
+ssize_t
+beiscsi_drvr_ver_disp(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ return snprintf(buf, PAGE_SIZE, BE_NAME "\n");
+}
diff --git a/drivers/scsi/be2iscsi/be_mgmt.h b/drivers/scsi/be2iscsi/be_mgmt.h
index c50cef6..291c684 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.h
+++ b/drivers/scsi/be2iscsi/be_mgmt.h
@@ -301,4 +301,7 @@ int be_mgmt_get_boot_shandle(struct beiscsi_hba *phba,
unsigned int mgmt_get_all_if_id(struct beiscsi_hba *phba);
int mgmt_set_vlan(struct beiscsi_hba *phba, uint16_t vlan_tag);
+
+ssize_t beiscsi_drvr_ver_disp(struct device *dev,
+ struct device_attribute *attr, char *buf);
#endif
--
1.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 05/19] be2iscsi: Display driver name and version in device attribute
2012-10-19 23:12 [PATCH v2 05/19] be2iscsi: Display driver name and version in device attribute John Soni Jose
@ 2012-10-24 7:00 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2012-10-24 7:00 UTC (permalink / raw)
To: John Soni Jose; +Cc: linux-scsi, Jayamohan Kallickal
On 10/19/2012 06:12 PM, John Soni Jose wrote:
> Signed-off-by: John Soni Jose <sony.john-n@emulex.com>
> Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
> ---
> drivers/scsi/be2iscsi/be_main.c | 2 ++
> drivers/scsi/be2iscsi/be_mgmt.c | 16 ++++++++++++++++
> drivers/scsi/be2iscsi/be_mgmt.h | 3 +++
> 3 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index 2d1bbb8..bd0f49f 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -153,8 +153,10 @@ BEISCSI_RW_ATTR(log_enable, 0x00,
> "\t\t\t\tIO Path Events : 0x10\n"
> "\t\t\t\tConfiguration Path : 0x20\n");
>
> +DEVICE_ATTR(beiscsi_drvr_ver, S_IRUGO, beiscsi_drvr_ver_disp, NULL);
> struct device_attribute *beiscsi_attrs[] = {
> &dev_attr_beiscsi_log_enable,
> + &dev_attr_beiscsi_drvr_ver,
> NULL,
> };
>
> diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
> index aab5dd3..1ec1db3 100644
> --- a/drivers/scsi/be2iscsi/be_mgmt.c
> +++ b/drivers/scsi/be2iscsi/be_mgmt.c
> @@ -1136,3 +1136,19 @@ int mgmt_set_vlan(struct beiscsi_hba *phba,
> free_mcc_tag(&phba->ctrl, tag);
> return 0;
> }
> +
> +/**
> + * beiscsi_drvr_ver_disp()- Display the driver Name and Version
> + * @dev: ptr to device not used.
> + * @attr: device attribute, not used.
> + * @buf: contains formatted text driver name and version
> + *
> + * return
> + * size of the formatted string
> + **/
> +ssize_t
> +beiscsi_drvr_ver_disp(struct device *dev, struct device_attribute *attr,
> + char *buf)
> +{
> + return snprintf(buf, PAGE_SIZE, BE_NAME "\n");
> +}
It seems this should just be some sort of standard attr. All drivers
should export the name and version in some standard place to make it
easy for users and tools. Maybe until that day this is ok?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-24 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-19 23:12 [PATCH v2 05/19] be2iscsi: Display driver name and version in device attribute John Soni Jose
2012-10-24 7:00 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).