From mboxrd@z Thu Jan 1 00:00:00 1970 From: taco Subject: Re: [patch,v2 05/10] sd: use alloc_disk_node Date: Mon, 05 Nov 2012 23:32:35 +0800 Message-ID: <5097DC13.9060809@gmail.com> References: <1351892763-21325-1-git-send-email-jmoyer@redhat.com> <1351892763-21325-6-git-send-email-jmoyer@redhat.com> <50954852.5050209@acm.org> <5097D3D2.9020407@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5097D3D2.9020407@acm.org> Sender: linux-kernel-owner@vger.kernel.org To: Bart Van Assche Cc: Jeff Moyer , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, "James E.J. Bottomley" List-Id: linux-scsi@vger.kernel.org On 11/05/2012 10:57 PM, Bart Van Assche wrote: > On 11/05/12 15:12, Jeff Moyer wrote: >> Bart Van Assche writes: >> >>> On 11/02/12 22:45, Jeff Moyer wrote: >>>> Signed-off-by: Jeff Moyer >>>> --- >>>> drivers/scsi/sd.c | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c >>>> index 12f6fdf..8deb915 100644 >>>> --- a/drivers/scsi/sd.c >>>> +++ b/drivers/scsi/sd.c >>>> @@ -2714,7 +2714,7 @@ static int sd_probe(struct device *dev) >>>> if (!sdkp) >>>> goto out; >>>> >>>> - gd = alloc_disk(SD_MINORS); >>>> + gd = alloc_disk_node(SD_MINORS, dev_to_node(dev)); >>>> if (!gd) >>>> goto out_free; >>> >>> shost->numa_node can be another NUMA node than dev_to_node(dev). Have >>> you considered using shost->numa_node here ? >> >> It can? How? > > E.g. if the LLD allows the user to specify the value of numa_node and > passes that value to scsi_host_alloc_node() (see also > http://lkml.org/lkml/2012/10/23/477 for further information). > >> Just so I'm clear, you're suggesting I use the scsi_device's host >> pointer to get to the Scsi_Host, and that *will* be filled in that this >> point, right? > > As far as I can see the sdev->host pointer is set in scsi_alloc_sdev() > and that happens before sd_probe() is invoked. > yes, struct scsi_device was created before sd, sd is the top layer. > Bart. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >