* be_main.c:273 always evaluates to 'false'
@ 2012-11-20 13:57 Hannes Reinecke
0 siblings, 0 replies; only message in thread
From: Hannes Reinecke @ 2012-11-20 13:57 UTC (permalink / raw)
To: Jayamohan Kallickal; +Cc: SCSI Mailing List
Hi Jayamohan,
drivers/scsi/be2iscsi/be_main.c:273 has this statement:
if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
continue;
which is pointless at best, and actually harmful at worst as it
probably should compare with the scmd as passed to
beiscsi_eh_device_reset(struct scsi_cmnd *sc)
You might want to fix it up.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-11-20 13:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-20 13:57 be_main.c:273 always evaluates to 'false' Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).