* [PATCH] hpsa: fix potential resource leak
@ 2012-12-03 12:13 Tomas Henzl
0 siblings, 0 replies; 5+ messages in thread
From: Tomas Henzl @ 2012-12-03 12:13 UTC (permalink / raw)
To: 'James.Bottomley@HansenPartnership.com'
Cc: 'linux-scsi@vger.kernel.org', Stephen M. Cameron
I think we should free also the cfgtable allocated a few lines
above this point.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 796482b..3cc18aa 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3858,7 +3858,7 @@ static __devinit int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
}
rc = write_driver_ver_to_cfgtable(cfgtable);
if (rc)
- goto unmap_vaddr;
+ goto unmap_cfgtable;
/* If reset via doorbell register is supported, use that.
* There are two such methods. Favor the newest method.
--
1.7.11.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] hpsa: fix potential resource leak
@ 2014-11-07 11:00 Tomas Henzl
0 siblings, 0 replies; 5+ messages in thread
From: Tomas Henzl @ 2014-11-07 11:00 UTC (permalink / raw)
To: linux-scsi; +Cc: don.brace, Elliott, brace77070
We should free the cfgtable allocated a few lines above.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 1ce2b43608..7d4cef779f 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5994,7 +5994,7 @@ static int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
}
rc = write_driver_ver_to_cfgtable(cfgtable);
if (rc)
- goto unmap_vaddr;
+ goto unmap_cfgtable;
/* If reset via doorbell register is supported, use that.
* There are two such methods. Favor the newest method.
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] hpsa: fix potential resource leak
@ 2014-11-07 12:27 Tomas Henzl
2014-11-07 12:49 ` Tomas Henzl
2014-11-10 14:17 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Tomas Henzl @ 2014-11-07 12:27 UTC (permalink / raw)
To: linux-scsi; +Cc: don.brace, Elliott, brace77070
We should free the cfgtable allocated a few lines above.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 1ce2b43608..7d4cef779f 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5994,7 +5994,7 @@ static int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
}
rc = write_driver_ver_to_cfgtable(cfgtable);
if (rc)
- goto unmap_vaddr;
+ goto unmap_cfgtable;
/* If reset via doorbell register is supported, use that.
* There are two such methods. Favor the newest method.
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hpsa: fix potential resource leak
2014-11-07 12:27 Tomas Henzl
@ 2014-11-07 12:49 ` Tomas Henzl
2014-11-10 14:17 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Tomas Henzl @ 2014-11-07 12:49 UTC (permalink / raw)
To: linux-scsi; +Cc: don.brace, Elliott, brace77070
My apologies for sending the same mail twice.
Please ignore this one.
--tms
On 11/07/2014 01:27 PM, Tomas Henzl wrote:
> We should free the cfgtable allocated a few lines above.
>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
> drivers/scsi/hpsa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 1ce2b43608..7d4cef779f 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -5994,7 +5994,7 @@ static int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
> }
> rc = write_driver_ver_to_cfgtable(cfgtable);
> if (rc)
> - goto unmap_vaddr;
> + goto unmap_cfgtable;
>
> /* If reset via doorbell register is supported, use that.
> * There are two such methods. Favor the newest method.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hpsa: fix potential resource leak
2014-11-07 12:27 Tomas Henzl
2014-11-07 12:49 ` Tomas Henzl
@ 2014-11-10 14:17 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2014-11-10 14:17 UTC (permalink / raw)
To: Tomas Henzl; +Cc: linux-scsi, don.brace, Elliott, brace77070
Don, can you help me review Tomas hpsa patches, including those from the
last week of October? Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-10 14:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-03 12:13 [PATCH] hpsa: fix potential resource leak Tomas Henzl
-- strict thread matches above, loose matches on Subject: below --
2014-11-07 11:00 Tomas Henzl
2014-11-07 12:27 Tomas Henzl
2014-11-07 12:49 ` Tomas Henzl
2014-11-10 14:17 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).